feat: integrate smb public instance #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshinongit
force-pushed
the
feat-integrate-smb-public-instance
branch
from
35e6d76 to
b85cebd
Compare
birme
approved these changes
Nov 28, 2023
src/server.ts
Outdated
| @@ -2,7 +2,7 @@ import api from './api'; | |||
|
|
|||
| const server = api({ title: '@eyevinn/typescript-nodejs' }); | |||
There was a problem hiding this comment.
Change this to intercom-manager instead
birme
force-pushed
the
feat-integrate-smb-public-instance
branch
from
b85cebd to
16be83e
Compare
birme
reviewed
Nov 28, 2023
| @@ -181,7 +197,7 @@ function getLine(productionLines: Line[], name: string): Line { | |||
| } | |||
|
|
|||
| const apiProductions: FastifyPluginCallback = (fastify, opts, next) => { | |||
| const smbServerUrl = 'http://localhost:8080/conferences/'; | |||
| const smbServerUrl = SMB_ADDRESS + '/conferences/'; | |||
There was a problem hiding this comment.
Prefer to use URL whenever constructing URL:s, example:
const smbServerUrl = (new URL('/conferences', SMB_ADDRESS)).toString()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include ssrc from client SDP answer used in the smb configure endpoint call.
Can set smb-address:port and endpoint timeout using env vars.