Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#95): can rename a line in a production #98

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat(#95): can rename a line in a production #98

merged 2 commits into from
Jun 25, 2024

Conversation

birme
Copy link
Contributor

@birme birme commented Jun 25, 2024

This PR will add a new endpoint to update the name of a line in a production.

PATCH /production/{productionId}/line/{lineId}

with the body:

{
  "name": "newlinename"
}

It returns

{
  "id": "<lineId>",
  "name": "newlinename"
}

More details in Swagger documentation is available

@birme birme requested a review from oshinongit June 25, 2024 08:05
@birme birme linked an issue Jun 25, 2024 that may be closed by this pull request
Can change name of a line in a production #95
Closed
oshinongit
oshinongit approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@oshinongit oshinongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birme birme merged commit 5613c8c into main Jun 25, 2024
4 checks passed
@birme birme deleted the 95-rename-line branch June 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshinongit oshinongit oshinongit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can change name of a line in a production
2 participants
@birme @oshinongit