-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Insecure Use of Regular Expressions (1)
More info on how to fix Insecure Use of Regular Expressions in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Dependency Scan (nodejs) | 0 | 2 | 1 | 2 | ✅ |
Secrets Audit | 0 | 4 | 0 | 0 | ❌ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sathian-icd Some of the pictures are not clear / not professional looking. Please recheck. Also, some of them have unnecessary objects in the image. It should be just the face directly. I noticed you changed a few pictures as well where the previous one looked much better, and the newer image is grainy. Better to revert that. Undo the commit and edit accordingly. Also, stick to the naming convention for the file names. Let's keep things consistent.
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
so, I made the changes you asked for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sathian-icd The following images have to be changed:
- public/images/team_2021/Gandheesh.jpg (I think that's some girl's hair in front of him)
- public/images/team_2021/Praanesh.jpg (Not clear)
- public/images/team_2021/Sukha.jpg (Looks like the image is horizontally squashed. Happens when the image is resized irrespective of aspect ratio instead of cropping)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also,
- public/images/team_2021/pranav.jpg (Is there a better picture where he's the subject than have other objects)
- public/images/team_2021/harsha.jpg (blurry)
I will make these changes as soon as I get these images. |
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
I've changed the images you mentioned. @aravindvnair99 |
@sathian-icd No fresh PR isn't required. I'll review this PR shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sathian-icd Just reviewed your PR. Everything looks good except public/images/team_2021/sukha.png
where the image looks squashed horizontally. The original image should be cropped and not resized.
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
…Bengaluru into newupdatebranch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Dependency Scan (nodejs) | 0 | 3 | 2 | 2 | ❌ |
Secrets Audit | 0 | 4 | 0 | 0 | ❌ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Secrets Audit | 0 | 4 | 0 | 0 | ❌ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Fixes #222
Proposed Changes
-Executives list updated
-Images are in 245x245 px and compressed