Skip to content
This repository has been archived by the owner on Feb 19, 2023. It is now read-only.

2020 - 2021 Update Part 2 #221

Merged
merged 27 commits into from
May 12, 2021
Merged

2020 - 2021 Update Part 2 #221

merged 27 commits into from
May 12, 2021

Conversation

sathian-icd
Copy link
Member

@sathian-icd sathian-icd commented Apr 22, 2021

Fixes #222

Proposed Changes

-Executives list updated
-Images are in 245x245 px and compressed

@guardrails
Copy link

guardrails bot commented Apr 22, 2021

⚠️ We detected 1 security issue in this pull request:

Insecure Use of Regular Expressions (1)
Docs Details
💡 Title: Regex DOS (ReDOS)
;window.Modernizr=function(a,b,c){function u(a){j.cssText=a}function v(a,b){return u(prefixes.join(a+";")+(b||""))}function w(a,b){return typeof a===b}function x(a,b){return!!~(""+a).indexOf(b)}function y(a,b,d){for(var e in a){var f=b[a[e]];if(f!==c)return d===!1?a[e]:w(f,"function")?f.bind(d||b):f}return!1}var d="2.8.3",e={},f=!0,g=b.documentElement,h="modernizr",i=b.createElement(h),j=i.style,k,l={}.toString,m={},n={},o={},p=[],q=p.slice,r,s={}.hasOwnProperty,t;!w(s,"undefined")&&!w(s.call,"undefined")?t=function(a,b){return s.call(a,b)}:t=function(a,b){return b in a&&w(a.constructor.prototype[b],"undefined")},Function.prototype.bind||(Function.prototype.bind=function(b){var c=this;if(typeof c!="function")throw new TypeError;var d=q.call(arguments,1),e=function(){if(this instanceof e){var a=function(){};a.prototype=c.prototype;var f=new a,g=c.apply(f,d.concat(q.call(arguments)));return Object(g)===g?g:f}return c.apply(b,d.concat(q.call(arguments)))};return e});for(var z in m)t(m,z)&&(r=z.toLowerCase(),e[r]=m[z](),p.push((e[r]?"":"no-")+r));return e.addTest=function(a,b){if(typeof a=="object")for(var d in a)t(a,d)&&e.addTest(d,a[d]);else{a=a.toLowerCase();if(e[a]!==c)return e;b=typeof b=="function"?b():b,typeof f!="undefined"&&f&&(g.className+=" "+(b?"":"no-")+a),e[a]=b}return e},u(""),i=k=null,function(a,b){function l(a,b){var c=a.createElement("p"),d=a.getElementsByTagName("head")[0]||a.documentElement;return c.innerHTML="x<style>"+b+"</style>",d.insertBefore(c.lastChild,d.firstChild)}function m(){var a=s.elements;return typeof a=="string"?a.split(" "):a}function n(a){var b=j[a[h]];return b||(b={},i++,a[h]=i,j[i]=b),b}function o(a,c,d){c||(c=b);if(k)return c.createElement(a);d||(d=n(c));var g;return d.cache[a]?g=d.cache[a].cloneNode():f.test(a)?g=(d.cache[a]=d.createElem(a)).cloneNode():g=d.createElem(a),g.canHaveChildren&&!e.test(a)&&!g.tagUrn?d.frag.appendChild(g):g}function p(a,c){a||(a=b);if(k)return a.createDocumentFragment();c=c||n(a);var d=c.frag.cloneNode(),e=0,f=m(),g=f.length;for(;e<g;e++)d.createElement(f[e]);return d}function q(a,b){b.cache||(b.cache={},b.createElem=a.createElement,b.createFrag=a.createDocumentFragment,b.frag=b.createFrag()),a.createElement=function(c){return s.shivMethods?o(c,a,b):b.createElem(c)},a.createDocumentFragment=Function("h,f","return function(){var n=f.cloneNode(),c=n.createElement;h.shivMethods&&("+m().join().replace(/[\w\-]+/g,function(a){return b.createElem(a),b.frag.createElement(a),'c("'+a+'")'})+");return n}")(s,b.frag)}function r(a){a||(a=b);var c=n(a);return s.shivCSS&&!g&&!c.hasCSS&&(c.hasCSS=!!l(a,"article,aside,dialog,figcaption,figure,footer,header,hgroup,main,nav,section{display:block}mark{background:#FF0;color:#000}template{display:none}")),k||q(a,c),a}var c="3.7.0",d=a.html5||{},e=/^<|^(?:button|map|select|textarea|object|iframe|option|optgroup)$/i,f=/^(?:a|b|code|div|fieldset|h1|h2|h3|h4|h5|h6|i|label|li|ol|p|q|span|strong|style|table|tbody|td|th|tr|ul)$/i,g,h="_html5shiv",i=0,j={},k;(function(){try{var a=b.createElement("a");a.innerHTML="<xyz></xyz>",g="hidden"in a,k=a.childNodes.length==1||function(){b.createElement("a");var a=b.createDocumentFragment();return typeof a.cloneNode=="undefined"||typeof a.createDocumentFragment=="undefined"||typeof a.createElement=="undefined"}()}catch(c){g=!0,k=!0}})();var s={elements:d.elements||"abbr article aside audio bdi canvas data datalist details dialog figcaption figure footer header hgroup main mark meter nav output progress section summary template time video",version:c,shivCSS:d.shivCSS!==!1,supportsUnknownElements:k,shivMethods:d.shivMethods!==!1,type:"default",shivDocument:r,createElement:o,createDocumentFragment:p};a.html5=s,r(b)}(this,b),e._version=d,g.className=g.className.replace(/(^|\s)no-js(\s|$)/,"$1$2")+(f?" js "+p.join(" "):""),e}(this,this.document),function(a,b,c){function d(a){return"[object Function]"==o.call(a)}function e(a){return"string"==typeof a}function f(){}function g(a){return!a||"loaded"==a||"complete"==a||"uninitialized"==a}function h(){var a=p.shift();q=1,a?a.t?m(function(){("c"==a.t?B.injectCss:B.injectJs)(a.s,0,a.a,a.x,a.e,1)},0):(a(),h()):q=0}function i(a,c,d,e,f,i,j){function k(b){if(!o&&g(l.readyState)&&(u.r=o=1,!q&&h(),l.onload=l.onreadystatechange=null,b)){"img"!=a&&m(function(){t.removeChild(l)},50);for(var d in y[c])y[c].hasOwnProperty(d)&&y[c][d].onload()}}var j=j||B.errorTimeout,l=b.createElement(a),o=0,r=0,u={t:d,s:c,e:f,a:i,x:j};1===y[c]&&(r=1,y[c]=[]),"object"==a?l.data=c:(l.src=c,l.type=a),l.width=l.height="0",l.onerror=l.onload=l.onreadystatechange=function(){k.call(this,r)},p.splice(e,0,u),"img"!=a&&(r||2===y[c]?(t.insertBefore(l,s?null:n),m(k,j)):y[c].push(l))}function j(a,b,c,d,f){return q=0,b=b||"j",e(a)?i("c"==b?v:u,a,b,this.i++,c,d,f):(p.splice(this.i++,0,a),1==p.length&&h()),this}function k(){var a=B;return a.loader={load:j,i:0},a}var l=b.documentElement,m=a.setTimeout,n=b.getElementsByTagName("script")[0],o={}.toString,p=[],q=0,r="MozAppearance"in l.style,s=r&&!!b.createRange().compareNode,t=s?l:n.parentNode,l=a.opera&&"[object Opera]"==o.call(a.opera),l=!!b.attachEvent&&!l,u=r?"object":l?"script":"img",v=l?"script":u,w=Array.isArray||function(a){return"[object Array]"==o.call(a)},x=[],y={},z={timeout:function(a,b){return b.length&&(a.timeout=b[0]),a}},A,B;B=function(a){function b(a){var a=a.split("!"),b=x.length,c=a.pop(),d=a.length,c={url:c,origUrl:c,prefixes:a},e,f,g;for(f=0;f<d;f++)g=a[f].split("="),(e=z[g.shift()])&&(c=e(c,g));for(f=0;f<b;f++)c=x[f](c);return c}function g(a,e,f,g,h){var i=b(a),j=i.autoCallback;i.url.split(".").pop().split("?").shift(),i.bypass||(e&&(e=d(e)?e:e[a]||e[g]||e[a.split("/").pop().split("?")[0]]),i.instead?i.instead(a,e,f,g,h):(y[i.url]?i.noexec=!0:y[i.url]=1,f.load(i.url,i.forceCSS||!i.forceJS&&"css"==i.url.split(".").pop().split("?").shift()?"c":c,i.noexec,i.attrs,i.timeout),(d(e)||d(j))&&f.load(function(){k(),e&&e(i.origUrl,h,g),j&&j(i.origUrl,h,g),y[i.url]=2})))}function h(a,b){function c(a,c){if(a){if(e(a))c||(j=function(){var a=[].slice.call(arguments);k.apply(this,a),l()}),g(a,j,b,0,h);else if(Object(a)===a)for(n in m=function(){var b=0,c;for(c in a)a.hasOwnProperty(c)&&b++;return b}(),a)a.hasOwnProperty(n)&&(!c&&!--m&&(d(j)?j=function(){var a=[].slice.call(arguments);k.apply(this,a),l()}:j[n]=function(a){return function(){var b=[].slice.call(arguments);a&&a.apply(this,b),l()}}(k[n])),g(a[n],j,b,n,h))}else!c&&l()}var h=!!a.test,i=a.load||a.both,j=a.callback||f,k=j,l=a.complete||f,m,n;c(h?a.yep:a.nope,!!i),i&&c(i)}var i,j,l=this.yepnope.loader;if(e(a))g(a,0,l,0);else if(w(a))for(i=0;i<a.length;i++)j=a[i],e(j)?g(j,0,l,0):w(j)?B(j):Object(j)===j&&h(j,l);else Object(a)===a&&h(a,l)},B.addPrefix=function(a,b){z[a]=b},B.addFilter=function(a){x.push(a)},B.errorTimeout=1e4,null==b.readyState&&b.addEventListener&&(b.readyState="loading",b.addEventListener("DOMContentLoaded",A=function(){b.removeEventListener("DOMContentLoaded",A,0),b.readyState="complete"},0)),a.yepnope=k(),a.yepnope.executeStack=h,a.yepnope.injectJs=function(a,c,d,e,i,j){var k=b.createElement("script"),l,o,e=e||B.errorTimeout;k.src=a;for(o in d)k.setAttribute(o,d[o]);c=j?h:c||f,k.onreadystatechange=k.onload=function(){!l&&g(k.readyState)&&(l=1,c(),k.onload=k.onreadystatechange=null)},m(function(){l||(l=1,c(1))},e),i?k.onload():n.parentNode.insertBefore(k,n)},a.yepnope.injectCss=function(a,c,d,e,g,i){var e=b.createElement("link"),j,c=i?h:c||f;e.href=a,e.rel="stylesheet",e.type="text/css";for(j in d)e.setAttribute(j,d[j]);g||(n.parentNode.insertBefore(e,n),m(c,0))}}(this,document),Modernizr.load=function(){yepnope.apply(window,[].slice.call(arguments,0))};

More info on how to fix Insecure Use of Regular Expressions in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Dependency Scan (nodejs) 0 2 1 2
Secrets Audit 0 4 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@sathian-icd sathian-icd changed the title PR 2020 - 2021 Update Part 2 2020 - 2021 Update Part 2 Apr 22, 2021
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sathian-icd Some of the pictures are not clear / not professional looking. Please recheck. Also, some of them have unnecessary objects in the image. It should be just the face directly. I noticed you changed a few pictures as well where the previous one looked much better, and the newer image is grainy. Better to revert that. Undo the commit and edit accordingly. Also, stick to the naming convention for the file names. Let's keep things consistent.

aravindvnair99 and others added 3 commits April 22, 2021 23:20
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
@sathian-icd
Copy link
Member Author

@sathian-icd Some of the pictures are not clear / not professional looking. Please recheck. Also, some of them have unnecessary objects in the image. It should be just the face directly. I noticed you changed a few pictures as well where the previous one looked much better, and the newer image is grainy. Better to revert that. Undo the commit and edit accordingly. Also, stick to the naming convention for the file names. Let's keep things consistent.

so, I made the changes you asked for.
I reverted the grainy new images to the old clear ones.
I've also updated new images for the grainy ones.
I also followed the old naming convention that you asked

Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sathian-icd The following images have to be changed:

  • public/images/team_2021/Gandheesh.jpg (I think that's some girl's hair in front of him)
  • public/images/team_2021/Praanesh.jpg (Not clear)
  • public/images/team_2021/Sukha.jpg (Looks like the image is horizontally squashed. Happens when the image is resized irrespective of aspect ratio instead of cropping)

Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also,

  • public/images/team_2021/pranav.jpg (Is there a better picture where he's the subject than have other objects)
  • public/images/team_2021/harsha.jpg (blurry)

@sathian-icd
Copy link
Member Author

I will make these changes as soon as I get these images.

@aravindvnair99 aravindvnair99 added EJS Issues or pull requests related to EJS Images Issues or pull requests related to images and removed security findings labels Apr 23, 2021
@aravindvnair99 aravindvnair99 added this to the 2020 - 2021 Update milestone Apr 23, 2021
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
@sathian-icd
Copy link
Member Author

I've changed the images you mentioned. @aravindvnair99
also, yash mentioned that you want me to create a fresh pull request

@aravindvnair99
Copy link
Member

@sathian-icd No fresh PR isn't required. I'll review this PR shortly.

Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sathian-icd Just reviewed your PR. Everything looks good except public/images/team_2021/sukha.png where the image looks squashed horizontally. The original image should be cropped and not resized.

@aravindvnair99 aravindvnair99 removed their assignment Apr 26, 2021
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
@aravindvnair99 aravindvnair99 linked an issue Apr 26, 2021 that may be closed by this pull request
15 tasks
@aravindvnair99 aravindvnair99 added the dependencies Pull requests that update a dependency file label May 12, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Dependency Scan (nodejs) 0 3 2 2
Secrets Audit 0 4 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Secrets Audit 0 4 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
@aravindvnair99 aravindvnair99 merged commit ec6fa46 into main May 12, 2021
@aravindvnair99 aravindvnair99 deleted the newupdatebranch branch May 12, 2021 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file EJS Issues or pull requests related to EJS Images Issues or pull requests related to images security findings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2020 - 2021 Update
2 participants