Application definition for XPS

[lukaspie]

• Extends the non-merged NXxps application definition from NXxps sub app-def #30.
  • Defines coordinate system
  • Different levels of requiredness compared to NXmpes.

I pulled this out of #170 because that one still needs a bit of discussion, but we can add the peak fitting to NXxps later.

[rettigl]

I think I don't understand all your transformations well, even not with the picture. I left some comments.

[lukaspie]

@domna here is an example config and nxs file for just the transformations
vms_cs.zip

[domna]

@domna here is an example config and nxs file for just the transformations vms_cs.zip

Thank you for this file. I found two small problems:

• I'm not sure of relative notation is supported if the fields are not in the same transformations group. At least the nexus3d tool couldn't follow it, but it's an easy fix
• There is a small error in entry/instrument/beam_xray. I think the depends_on must be transformations/beam_azimuth_angle and not transformations/source_azimuth_angle

[domna]

I only commented on one transformation but the other ones look similar and I think the same changes should be applied there.

[lukaspie]

@domna here is an example config and nxs file for just the transformations vms_cs.zip

Thank you for this file. I found two small problems:

• I'm not sure of relative notation is supported if the fields are not in the same transformations group. At least the nexus3d tool couldn't follow it, but it's an easy fix

Where do you see this relative notation? You mean "depends_on": "transformations/beam_azimuth_angle" should be the full path?

• There is a small error in entry/instrument/beam_xray. I think the depends_on must be transformations/beam_azimuth_angle and not transformations/source_azimuth_angle

Fixed (it is in the config on the reader side), you were right.

[lukaspie]

@domna this should bre ready for review. Here is the updated example:
vms_cs_updated.zip

[domna]

@domna this should bre ready for review. Here is the updated example: vms_cs_updated.zip

The electronanalyser lies at the same position as the beam in the example. Also the same values are read for both (e.g., @xps_token:beam_xray/source_polar_angle for the polar angle). Is this a typo?

[lukaspie]

@domna I think we can merge this now and then refactor it once we have a proper description of transformations in #235