Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD for yaml/nxdl consistency #70

Merged
merged 14 commits into from
Oct 5, 2023
Merged

CI/CD for yaml/nxdl consistency #70

merged 14 commits into from
Oct 5, 2023

Conversation

domna
Copy link

@domna domna commented Sep 25, 2023

This checks whether yaml and nxdl are in sync in the repository.
It generates nxdl from yaml and checks for uncommited changes and fails if there are any, which means that there is a difference in the newly generated nxdl.

Here is an example of the check failing (NXmpes deliberately out of sync):
https://github.com/FAIRmat-NFDI/nexus_definitions/actions/runs/6297815343/job/17095508513

Changes

  • Re-adds all corresponding yaml files
  • Adds CI/CD to check consistency of yaml and nxdl
  • Adds *_parsed.yaml files to .gitignore!
  • Updates favicon of the pages to area B logo (was nexus logo previously)

@domna domna marked this pull request as ready for review September 25, 2023 11:12
@domna domna requested a review from sanbrock September 25, 2023 11:12
Copy link

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore Show resolved Hide resolved
@domna domna merged commit 1a69480 into fairmat Oct 5, 2023
6 checks passed
@domna domna deleted the yaml-nxdl-consistency branch October 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants