Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes makefile pickung up nxdl rules for make nyaml #73

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

domna
Copy link

@domna domna commented Sep 28, 2023

This fixes make nyaml breaking the build on second run (when yaml files are present), because it picks up the nyaml rules.
This PR removes the dependency in the make rule because we don't need it there and can simply use it as a variable.

As this was reported by @RubelMozumder : Can you check if everything is fine now?

This change was also committed to nexusformat#1303

Copy link

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domna domna merged commit b2dbb48 into fairmat Oct 5, 2023
5 checks passed
@domna domna deleted the fix-makefile branch October 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants