-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Feature/update pixdim4 for the final *bold outputs #2154
Open
birajstha
wants to merge
12
commits into
develop
Choose a base branch
from
feature/update_pixdim4
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
467818f
Adding utility functions for validating TR in CPAC output bolds
birajstha 21a2711
Adding validation node for TR of bold outputs
birajstha e82d9da
minor name correction for node
birajstha fd16170
Adding validation node before data sink
birajstha 545cd74
Adding doc-strings and exception handling to utility functions
birajstha 23b13f1
correcting the workflow connection
birajstha ea5282b
correcting the workflow connection
birajstha 0fe8c58
renaming input RawSource to correct value RawSource_bold
birajstha 4ac8e3a
changing validation input from renamed node nii_out
birajstha 8495759
changing validation input from renamed node nii_out
birajstha 06fba22
added to changelog
birajstha 0788215
moving the node declaration inside the if block
birajstha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to worry about
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this one. May be @sgiavasis could advise on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason to use AFNI
3drefit
instead ofnibabel
is to change theTime step
in3dinfo
as well along withpixdim4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this further. It seems that it only refers to, and impacts, an AFNI-specific slice-timing setting in the header, which can be checked using
3dinfo -slice_timing
.I ran this on several different datasets and found all of them to be unset:
0.000000|0.000000|0.000000|0.000000|0.000000|0.000000|... etc.
This was both raw data and final outputs, just to make sure C-PAC wasn't clearing this setting as well.
I am pretty sure this is an esoteric and rarely-used setting. As we know, slice-timing offsets and sequences are now contained in BIDS sidecars. But in the interest in keeping up with the theme of this issue and PR, where we maintain the old header information in case a user wants to run post-processing using some non-BIDS-enabled tools, I would still want to avoid inadvertently changing an AFNI header slice-timing offset to something wrong.
So the question remains, how often is this setting actually populated? Again, I think rarely. But if it is, when a tool invoked by C-PAC clobbers the TR value in the
pixdim4
header field, is it also clobbering this field? I doubt it, and if we run3drefit -TR
and it scalesnewTR/oldTR
like the3drefit
docs say, it might scale by, let's say,0.8/1.0
as it would in our recent specific case.Also curious about
-Tslices
- can this be used blankly with no parameter, to keep it the same, but prevent the scaling? May be worth manually setting this AFNI header field with the offsets from the sidecar, then trying a few of these permutations out.