Merge pull request #3595 from alyssarosenzweig/ir/before

Factor out SetWriteCursorBefore
FEX-Emu · Apr 23, 2024 · a0bf6a4 · a0bf6a4
2 parents 7b88b0f + 2372c94
commit a0bf6a4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/FEXCore/Source/Interface/IR/IREmitter.h b/FEXCore/Source/Interface/IR/IREmitter.h
@@ -245,6 +245,15 @@ class IREmitter {
     CurrentWriteCursor = Node;
   }
 
+  // Set cursor to write before Node
+  void SetWriteCursorBefore(OrderedNode* Node) {
+    auto IR = ViewIR();
+    auto Before = IR.at(Node);
+    --Before;
+
+    SetWriteCursor(std::get<0>(*Before));
+  }
+
   OrderedNode* GetWriteCursor() {
     return CurrentWriteCursor;
   }

diff --git a/FEXCore/Source/Interface/IR/Passes/ConstProp.cpp b/FEXCore/Source/Interface/IR/Passes/ConstProp.cpp
@@ -639,10 +639,7 @@ bool ConstProp::ConstantPropagation(IREmitter* IREmit, const IRListView& Current
         IROp->Op = OP_ADDWITHFLAGS;
       }
 
-      // Set the write cursor to just before this operation.
-      auto CodeIter = CurrentIR.at(CodeNode);
-      --CodeIter;
-      IREmit->SetWriteCursor(std::get<0>(*CodeIter));
+      IREmit->SetWriteCursorBefore(CodeNode);
 
       // Negate the constant.
       auto NegConstant = IREmit->_Constant(-Constant2);