Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDUtils: Fix get_fdpath #1799

Merged
merged 1 commit into from
Jun 24, 2022
Merged

FDUtils: Fix get_fdpath #1799

merged 1 commit into from
Jun 24, 2022

Conversation

skmp
Copy link
Contributor

@skmp skmp commented Jun 24, 2022

Our get_fdpath was broken and would include junk data after the filename, as readlinkat does not null terminate,it returns length instead.

Sonicadvance1
Sonicadvance1 approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch.

@Sonicadvance1 Sonicadvance1 merged commit aa17f64 into main Jun 24, 2022
@Sonicadvance1 Sonicadvance1 deleted the skmp/fix-get_fdpath branch June 24, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonicadvance1 Sonicadvance1 Sonicadvance1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skmp @Sonicadvance1