Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRLoader/TestHarnessLoader: Don't build if not building tests #1926

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

Sonicadvance1
Copy link
Member

If we're not building tests then just don't build the IRLoader since it
won't get used.

@Sonicadvance1 Sonicadvance1 changed the title IRLoader: Don't build if not building tests IRLoader/TestHarnessLoader: Don't build if not building tests Aug 18, 2022
If we're not building tests then just don't build the IRLoader since it
won't get used.
@skmp
Copy link
Contributor

skmp commented Aug 18, 2022

How about using the EXCLUDE_FROM_ALL functionality to make the Loaders not built by default, and to bring them in the build only if some other dep (eg, a unit test) needs them?

@skmp
Copy link
Contributor

skmp commented Aug 18, 2022

set_target_properties(MyTarget PROPERTIES EXCLUDE_FROM_ALL TRUE)

${LIBS}
LinuxEmulation
${PTHREAD_LIB}
)

# add_executable(UnitTestGenerator UnitTestGenerator.cpp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now has misleading indentation.

@skmp skmp merged commit 097184c into FEX-Emu:main Aug 21, 2022
@Sonicadvance1 Sonicadvance1 deleted the no_irloader_on_no_tests branch August 21, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Unschedulled
Development

Successfully merging this pull request may close these issues.

3 participants