FEXLoader: Drop the binfmt_misc I flag
#4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream has rejected this flag which would have let FEX close the gap in functionality between binfmt_misc interpreters and PT_INTERP interpreters for how `/proc/exe` is handled. Since we are unable to change their opinions, just remove the code from FEX since it's never going to happen. Removes a little bit of confusing behaviour in execveat and filemanagement handling. Leaving us with only the regular confusing behaviour of trying to track accesses to `/proc/exe` instead.
lioncash
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has rejected this flag which would have let FEX close the gap in functionality between binfmt_misc interpreters and PT_INTERP interpreters for how
/proc/exeis handled. Since we are unable to change their opinions, just remove the code from FEX since it's never going to happen.Removes a little bit of confusing behaviour in execveat and filemanagement handling. Leaving us with only the regular confusing behaviour of trying to track accesses to
/proc/exeinstead.