Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure features are found/not found in our comprehensive builds #3336

Closed
wants to merge 31 commits into from

Conversation

jhale
Copy link
Member

@jhale jhale commented Aug 6, 2024

I noticed that KAHIP wasn't being found. This PR enables explicit dependency checks on our kitchen sink build to catch silent mistakes. KAHIP issue still needs fixing.

Also includes #3335.

jhale and others added 27 commits August 6, 2024 16:23
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
@jhale jhale changed the title Make sure features are being actually found in our kitchen sink build. Ensure features are found/not found in our comprehensive builds Aug 7, 2024
@mscroggs mscroggs added this to the 0.9.0 milestone Sep 3, 2024
@garth-wells
Copy link
Member

This PR mixes some unrelated changes - can it be simplified to just include the CMake CI changes?

@jhale
Copy link
Member Author

jhale commented Sep 11, 2024

Yes - I will tidy and merge #3335 first and then rebase this on top.

@jhale jhale closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants