-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go rewrite #8
Merged
Merged
Go rewrite #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marshyski - can you write a quick description of the change or link to an issue? thanks. |
@kood1 updated description of PR. |
Thanks @marshyski. It looks like CI build is failing. Can you take a look? |
@marshyski nvm, it passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite from Python to Go. It is backwards compatible with the REST interfaces and configurations minus the rate limiting (buffering was added to depreciate that feature). All libraries are vendored in this project so it can be checked out and built without pulling from internet sources. There are a couple of optimizations in this implementation (listed below). You should get next to no-blocking of uploading RPMs to a repo with this implementation. Still have to tweak the buffering to do batches in high-stress periods. Performance benefits should be at least 3-10x improvement and minus the operational hassles of a Python project, see issue #5
Performance benefits: