Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not edit score after commit for 1.1.0-1 #430

Closed
firstrgv opened this issue Oct 19, 2019 · 13 comments
Closed

Can not edit score after commit for 1.1.0-1 #430

firstrgv opened this issue Oct 19, 2019 · 13 comments

Comments

@firstrgv
Copy link

firstrgv commented Oct 19, 2019

Had a league meet today using 1.1.0, tablet scoring. We had an error in one match and went back to edit and as soon as we clicked edit it zeroed out the match but would let us edit it. We canceled the edit and just advised the team we would solve the issue before the next match. We did not have this problem in 1.0.0.

We have another league meet this coming weekend and need a workaround or fix please.

No other bugs noted. Thanks

@adwiii
Copy link

adwiii commented Oct 20, 2019

Can you post the logs here and the downloaded archive db for the event? Were you able to make the edit later on?

@firstrgv
Copy link
Author

firstrgv commented Oct 20, 2019 via email

@jvens
Copy link

jvens commented Oct 20, 2019

I had a report of the exact same issue from one of the scorekeepers at a league meet in Iowa this weekend. They attempted to edit a match score after it had been committed and when they clicked edit he said all of the scores were cleared out. The score change wasn't going to effect the outcome of the match, so they just decided it wasn't worth fighting to change it. I have asked the scorekeeper to send me the logs and as soon as he does I will post them here.

@adwiii
Copy link

adwiii commented Oct 20, 2019

@jvens do you know which meet it was?

@jvens
Copy link

jvens commented Oct 20, 2019

It was Mandalore Meet 1 (mandalore_2019_10_19_meet1)

@jvens
Copy link

jvens commented Oct 21, 2019

Attached are the log files. The one from 10/16 is from when I imported the event that had been created on v1.1.0 into a server running v1.1.1. The log from 10/19 is the actual event day. They were running the TOA DataSync which is why there are all the extra API calls in the log.

2019_10_16_12_47_29_PM_err.log
2019_10_19_08_33_46_AM_err.log

Let me know if there is anything else I can provide that would be helpful.

@adwiii adwiii changed the title Can not edit score after commit for 1.0.1 Can not edit score after commit for 1.1.1 Oct 21, 2019
@adwiii adwiii changed the title Can not edit score after commit for 1.1.1 Can not edit score after commit for 1.1.0-1 Oct 21, 2019
@adwiii
Copy link

adwiii commented Oct 21, 2019

@jvens I know you are reporting this second hand, but do you know for sure which match it is? (my guess is match 4). Also, do you know if this issue persists if the system is restarted? I have not been able to duplicate the issue locally - all of the matches allow me to edit them with proper scores. I will keep trying, but any additional details you have would be helpful.

I am also curious if the electronic score sheets in the Match Result report was incorrect, though I realize that was not checked in the moment. From the event home page, the Match Results link provides a page where you can select to view the score sheets for every match. For match 4 for example it would be http://localhost/event/mandalore_2019_10_19_meet1/match/q4/ which shows the Red and Blue score sheets rendered side by side. These show correctly for me locally. If you encounter this again it would be useful to know.

@firstrgv and @jvens in any case, we want to make the scores are right since it will affect rankings (TBP and highest score possibly) moving forward since league meet matches carry over. If you cannot make the edits locally, do you know what changes need to be made and I can make them for you and send you the proper db?

@firstrgv
Copy link
Author

firstrgv commented Oct 21, 2019 via email

@jvens
Copy link

jvens commented Oct 22, 2019

@adwiii, I asked for more details and the scorekeeper screen captured the exact steps that he did on Saturday. He was unable to replicate the issue even using the same score system, but shows exactly what steps he took to do it. Also, you are correct that it was match 4 that the issue occurred.

Here is the screen capture he sent me: https://youtu.be/tseILme3Vp8

I will be able to fix the match score in the database before I import it into the next league meet.

@ftctechnh
Copy link
Contributor

@firstrgv
Jason - when is your next league meet scheduled? Is it this Saturday (10/26)?

@firstrgv
Copy link
Author

firstrgv commented Oct 22, 2019 via email

@ftctechnh
Copy link
Contributor

@firstrgv @jvens
Thanks folks for reporting this issue. I am able to reproduce the issue and have provided some info to the developers that hopefully will help them identify and resolve the issue.

Until a fix is released for bug, if you need to edit the score for a match that has been already committed, then you will need to follow the workaround as described in the following YouTube video to edit, save and commit the updated score:

https://youtu.be/s6eNSTtcsYg

We'll post updates on this issue thread as they become available. Thanks again for your help in identifying this problem.

@adwiii
Copy link

adwiii commented Oct 30, 2019

This has been fixed in v1.1.2

@adwiii adwiii closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants