-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev branch #354
Draft
Ty9000
wants to merge
15
commits into
FOGProject:dev-branch
Choose a base branch
from
Ty9000:dev-branch
base: dev-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dev branch #354
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ecdc6a4
Add files via upload
Ty9000 9431908
Add files via upload
Ty9000 750b368
Add files via upload
Ty9000 2f439d5
Add files via upload
Ty9000 c0f4232
Add files via upload
Ty9000 65f4ed3
Add files via upload
Ty9000 ba59756
Add files via upload
Ty9000 bf7d80d
Add files via upload
Ty9000 d8da9cd
Add files via upload
Ty9000 010a4d4
Add files via upload
Ty9000 0fd2124
Add files via upload
Ty9000 8ca6ae8
Add files via upload
Ty9000 a8578d5
Add files via upload
Ty9000 b29588b
Add files via upload
Ty9000 16a2e07
Add files via upload
Ty9000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ty9000 You probably changed to hostname because you use a proper SSL certificate with hostname in it. I think we'll stick to IP address for now because we cannot rely on people having a proper DNS configuration for their server. We'd probably need to ask during setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! That's my bad. I'm just so used to having DNS as being authoritative, I made those changes for my own sanity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we provide both instances:
This can be done by opening a browser to either on or the other......
If you built your own certificate you can test this by using the hostname.
${httpproto}://${ipaddress}${webroot}management
${httpproto}://${hostname}${webroot}management