Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed folio_put/post arguments and added configurable http timeout #59

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fixed folio_put/post arguments and added configurable http timeout #59

merged 1 commit into from
Apr 25, 2024

Conversation

bltravis
Copy link
Contributor

Fixes #57 and makes HTTP timeout now configurable via FOLIOCLIENT_HTTP_TIMEOUT environment variable.

@bltravis
Removed verify argument from put/post methods and made httpx timeout …
74a6579 
…value configurable via FOLIOCLIENT_HTTP_TIMEOUT env variable.
@bltravis bltravis linked an issue Apr 25, 2024 that may be closed by this pull request
folio_put/post have unneeded argument #57
Closed
@bltravis bltravis merged commit aa5976d into master Apr 25, 2024
3 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bltravis bltravis deleted the 57-folio_putpost-have-unneeded-argument branch April 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

folio_put/post have unneeded argument
1 participant
@bltravis