Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower net usage #330

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Lower net usage #330

merged 1 commit into from
Mar 20, 2024

Conversation

wrefgtzweve
Copy link
Contributor

@wrefgtzweve wrefgtzweve commented Mar 17, 2024

Cherry picked UInt size & :GetTable() changes from #325

Based on https://github.com/Facepunch/garrysmod/blob/master/garrysmod/lua/includes/extensions/net.lua#L56-L97, cant directly uses these functions as FPP sents

I did notice that FPP sends a -1 if the owner isn't valid, but because we're using UInt it'll instead send the max possible int size, this undefined behaviour wont change with this pr.

Copy link
Owner

@FPtje FPtje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FPtje FPtje merged commit 735887e into FPtje:master Mar 20, 2024
1 check passed
@wrefgtzweve wrefgtzweve deleted the reduce-net-usage branch March 20, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants