Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaption in load.timeseries_opsd ... #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

adaption in load.timeseries_opsd ... #14

wants to merge 6 commits into from

Conversation

martacki
Copy link

... according to new format of opsd output file (_load_old is not up to date, new input data for GB and additional years). Won't be compatible with the current version of pypsa-eur (data/bundle should be updated simultaneously when merging into master)

Copy link
Member

@coroa coroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Fine by me! All other countries are represented accurately?

To coordinate the merge with pypsa-eur it would be best to:

  • release a new vresutils minor version (0.3.1), since there have been a couple of commits since
  • lock pypsa-eur to the previous release (ie. pip version constraint instead of git+https)
  • then merge this PR
  • release a new vresutils version
  • update the pypsa-eur data bundle with the new data files and add a lower bound version constraint instead for vresutils

@fneum I just released the vresutils version 0.3.1, it would be good to pin this version in the next pypsa-eur release to be able to merge this PR to master, or have some other work around!

You could also decide to copy this code straight to pypsa-eur master, and slowly get rid of yet another vresutils dependency?

@coroa coroa changed the title adaption in load.timeseries_opsd ... [DNMY] adaption in load.timeseries_opsd ... Jan 21, 2020
@martacki
Copy link
Author

martacki commented Jan 21, 2020

Fine by me! All other countries are represented accurately?

Actually, there are few other "holes", but those were present in the old load data as well and not corrected by interpolation or copying slices from previous weeks in CH, IE, IS and NO.
Total demand seems also higher in the new data (up to 20%), but closer to what I found on other sources (like statista)

GR and EE have the same missing hours, no changes there.

Other few have still missing data for 2019.

@coroa
Copy link
Member

coroa commented Jan 22, 2020

Actually, there are few other "holes", but those were present in the old load data as well and not corrected by interpolation or copying slices from previous weeks in CH, IE, IS and NO.

It probably makes sense to stitch those as well. Not a prerequisite for this change.

The problem with interpolation is that for gaps larger than maybe 2-3 hours, it produces wrong results.

One easy improvement would be to blanket apply interpolate(limit=2) to not touch gaps larger than to 2 hours, i think. Please check!

…n function additional timeslices for better accuracy. timeslices up to 4 hours remain interpolated
@martacki
Copy link
Author

It probably makes sense to stitch those as well. Not a prerequisite for this change.

The problem with interpolation is that for gaps larger than maybe 2-3 hours, it produces wrong results.

One easy improvement would be to blanket apply interpolate(limit=2) to not touch gaps larger than to 2 hours, i think. Please check!

I adapted those for the years [2010,2018], interpolation is now for max. 4 hours, larger timeframes are copied from couple days ahead. Only GB is missing data for a whole month, GR is missing a week or so, other "holes" are maximal 1-2 days.

Copy link
Member

@coroa coroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. A couple of comments.

vresutils/load.py Outdated Show resolved Hide resolved
vresutils/load.py Outdated Show resolved Hide resolved
vresutils/load.py Outdated Show resolved Hide resolved
vresutils/load.py Outdated Show resolved Hide resolved
vresutils/load.py Outdated Show resolved Hide resolved
vresutils/load.py Outdated Show resolved Hide resolved
@coroa coroa changed the title [DNMY] adaption in load.timeseries_opsd ... adaption in load.timeseries_opsd ... Jun 10, 2020
@coroa
Copy link
Member

coroa commented Jun 10, 2020

@eb5194 Another last look before you would be happy to merge this?

@martacki
Copy link
Author

@eb5194 Another last look before you would be happy to merge this?

should be all right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants