Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small collection of patches that fix issues found by valgrind #1

Merged
merged 3 commits into from
Dec 16, 2016
Merged

A small collection of patches that fix issues found by valgrind #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eefe20
lib: Ensure ptrs are NULL on free
donaldsharp Dec 16, 2016
26acb92
bgpd: Cleanup double read of free'd data
donaldsharp Dec 16, 2016
c9d5bd2
bgpd: Fix 'show ip bgp summary' variable output being wrong
donaldsharp Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bgpd/bgp_updgrp_adv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,8 +573,9 @@ subgroup_clear_table (struct update_subgroup *subgrp)

SUBGRP_FOREACH_ADJ_SAFE (subgrp, aout, taout)
{
bgp_adj_out_remove_subgroup (aout->rn, aout, subgrp);
bgp_unlock_node (aout->rn);
struct bgp_node *rn = aout->rn;
bgp_adj_out_remove_subgroup (rn, aout, subgrp);
bgp_unlock_node (rn);
}
}

Expand Down
4 changes: 4 additions & 0 deletions bgpd/bgp_vty.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10317,6 +10317,10 @@ bgp_show_summary (struct vty *vty, struct bgp *bgp, int afi, int safi,

if (peer->afc[afi][safi])
{
memset(dn_flag, '\0', sizeof(dn_flag));
if (peer_dynamic_neighbor(peer))
dn_flag[0] = '*';

if (peer->hostname && bgp_flag_check(bgp, BGP_FLAG_SHOW_HOSTNAME))
sprintf(neighbor_buf, "%s%s(%s) ", dn_flag, peer->hostname, peer->host);
else
Expand Down
6 changes: 5 additions & 1 deletion lib/routemap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1845,9 +1845,13 @@ route_map_finish (void)
}

for (i = 1; i < ROUTE_MAP_DEP_MAX; i++)
hash_free(route_map_dep_hash[i]);
{
hash_free(route_map_dep_hash[i]);
route_map_dep_hash[i] = NULL;
}

hash_free (route_map_master_hash);
route_map_master_hash = NULL;
}

/* Initialization of route map vector. */
Expand Down