Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: supports to listen teamd nlmsg as bond type #14712

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

yenlu-keith
Copy link
Contributor

this feature is to support teamd driver when configing ethernet segment's id and sys_mac via vtysh/zebra.

there are 2 approaches to support lacp protocol.
1st: linux bonding driver via tool (ifenslave_2.13~deb11u1_all.deb) via ip link cli command.
2nd: via teamd driver by nlmsg
https://github.com/jpirko/libteam/blob/master/libteam/libteam.c#L477

example for nlmsg from bonding driver:
https://cpp.hotexamples.com/examples/-/-/rtnl_link_add/cpp-rtnl_link_add-function-examples.html

comparison between bonding driver and teamd driver:
https://github.com/jpirko/libteam/wiki/Bonding-vs.-Team-features

hence, support teamd driver as what bonding driver does. we should add teamd nlmsg as bond type so that we are able to config associated es data.

@ton31337
Copy link
Member

ton31337 commented Nov 2, 2023

Thanks for your contribution to FRR!

One of your commits has an improperly formatted commit message
One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
One of your commits does not have a blank line between the summary and body; this will break git log --oneline

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@yenlu-keith yenlu-keith changed the title zebra supports to listen teamd nlmsg as bond type zebra: supports to listen teamd nlmsg as bond type Nov 6, 2023
this feature is to support teamd driver when configuring
ethernet segment's id and sys_mac via vtysh/zebra.

Signed-off-by: yenlu <yenlu@cisco.com>
@frrbot frrbot bot added the zebra label Nov 9, 2023
@github-actions github-actions bot added the rebase PR needs rebase label Nov 9, 2023
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@donaldsharp donaldsharp merged commit 858cc75 into FRRouting:master Nov 14, 2023
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants