-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bgp musings #15563
base: master
Are you sure you want to change the base?
Bgp musings #15563
Conversation
f0a64ad
to
9112222
Compare
bgpd/bgp_route.c
Outdated
@@ -12594,6 +12599,12 @@ DEFUN(show_ip_bgp_afi_safi_statistics, show_ip_bgp_afi_safi_statistics_cmd, | |||
json = json_object_new_object(); | |||
json_object_object_add(json, get_afi_safi_str(afi, safi, true), | |||
json_afi_safi); | |||
json_object_int_add(json, "bgpBestPathCalls", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be this in bgp_table_stats_single()
? Because what if we have show bgp vrf all statistics json
? Also, is this only for JSON output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because it's not per afi/safi, it's per struct bgp
. I intentionally only made this as a json output because most operators will not care about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not afi/safi, but per-instance (BGP, let's say lots of VRFs), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it's per router bgp XXX
in the cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this means that show bgp vrf all statistics json
won't work as expected, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly tested this branch, and I got a bgpd crash when using show bgp vrf all statistics json
.
9112222
to
2bda497
Compare
Still have a crash:
|
CI:rerun Rerun after fixing git access on CI infra |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
2bda497
to
692fde6
Compare
@ton31337 -> I don't disagree that you are getting a crash. But it's not in code that I wrote. There is no handler written for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can we fix frrbot styling issues?
692fde6
to
93a8548
Compare
There are a bunch of jhash_1word uses. Let's convert to jhash_3word and get rid of some calls. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Fill out a bit more data about what is being held. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Add some counters to keep track how often stuff is done. This is mainly for us developers. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
93a8548
to
1115fee
Compare
ospf convergence failure ... rerunning that single test |
a) Make attribute hash faster? convert jhash_1word to jhash_3words so we make less calls
b) Extend
show bgp attribute-info
to dump more datac) Gather some data around how many times path_info_cmp is called and how many times we double enqueue and defer enqueuing.