zebra: fix evpn mh bond member proto reinstall #16252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport dev/10.1 stable/10.0 stable/9.1 |
✅ Backports have been created
|
ton31337
reviewed
Jun 20, 2024
In case of EVPN MH bond, a member port going in
protodown state due to external reason (one case being linkflap),
frr updates the state correctly but upon manually
clearing external reason trigger FRR to reinstate
protodown without any reason code.
Fix is to ensure if the protodown reason was external
and new state is to have protodown 'off' then do no reinstate
protodown.
Ticket: #3947432
Testing:
switch:#ip link show swp1
4: swp1: <NO-CARRIER,BROADCAST,MULTICAST,SLAVE,UP> mtu 9216 qdisc
pfifo_fast master bond1 state DOWN mode DEFAULT group default qlen
1000
link/ether 1c:34:da:2c:aa:68 brd ff:ff:ff:ff:ff:ff protodown on
protodown_reason <linkflap>
switch:#ip link set swp1 protodown off protodown_reason linkflap off
switch:#ip link show swp1
4: swp1: <NO-CARRIER,BROADCAST,MULTICAST,SLAVE,UP> mtu 9216 qdisc
pfifo_fast master bond1 state DOWN mode DEFAULT group default qlen
1000
link/ether 1c:34:da:2c:aa:68 brd ff:ff:ff:ff:ff:ff
Signed-off-by: Chirag Shah <chirag@nvidia.com>
This was referenced Jun 21, 2024
ton31337
added a commit
that referenced
this pull request
Jun 21, 2024
zebra: fix evpn mh bond member proto reinstall (backport #16252)
ton31337
added a commit
that referenced
this pull request
Jun 21, 2024
zebra: fix evpn mh bond member proto reinstall (backport #16252)
ton31337
added a commit
that referenced
this pull request
Jun 22, 2024
zebra: fix evpn mh bond member proto reinstall (backport #16252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of EVPN MH bond, a member port going in protodown state due to external reason (one case being linkflap),
frr updates the state correctly but upon manually clearing external reason trigger FRR to reinstate protodown without any reason code.
Fix is to ensure if the protodown reason was external and new state is to have protodown 'off' then do no reinstate protodown.
Testing:
Signed-off-by: Chirag Shah chirag@nvidia.com