Netns Support / framework for supporting vrf with netns backend #1633

pguibert6WIND · 2018-01-12T15:50:59Z

this is the continuation of #1587.

NetDEF-CI · 2018-01-12T16:08:17Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1604 amd64 build: Failed

Configure failed for Ubuntu1604 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI014BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1604 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI014BUILD/config.log/config.log

Ubuntu1404 amd64 build: Failed

Configure failed for Ubuntu1404 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI001BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1404 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI001BUILD/config.log/config.log

FreeBSD11 amd64 build: Failed

Make failed for FreeBSD11 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI009BUILD/ErrorLog/log_make.txt)

       ^~~~~~~
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: fatal error: sys/inotify.h: No such file or directory
 #include <sys/inotify.h>
                         ^
compilation terminated.
*** Error code 1
Stop.
make[2]: stopped in /usr/home/ci/cibuild.2310/frr-source

FreeBSD11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI009BUILD/config.status/config.status

Debian8 amd64 build: Failed

Debian8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI008BLD/config.log/config.log
Configure failed for Debian8 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI008BLD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS6 amd64 build: Failed

Configure failed for CentOS6 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI006BUILD/ErrorLog/log_configure.txt)

checking for PYTHON... no
checking for PYTHON... yes
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI006BUILD/config.log/config.log

NetBSD6 amd64 build: Failed

Make failed for NetBSD6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI007BUILD/ErrorLog/log_make.txt)

/usr/include/string.h:64:7: note: expected 'const char * restrict' but argument is of type 'int'
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: fatal error: sys/inotify.h: No such file or directory
compilation terminated.
*** Error code 1
Stop.
make: stopped in /home/ci/cibuild.2310/frr-source
*** Error code 1
Stop.

NetBSD6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI007BUILD/config.status/config.status

FreeBSD9 amd64 build: Failed

Make failed for FreeBSD9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI004BUILD/ErrorLog/log_make.txt)

zebra/zserv.c:200: warning: passing argument 2 of 'strncpy' makes pointer from integer without a cast
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: error: sys/inotify.h: No such file or directory
zebra/zebra_ns_notify.c: In function 'zebra_ns_ready_read':
zebra/zebra_ns_notify.c:128: warning: implicit declaration of function 'setns'
zebra/zebra_ns_notify.c:128: error: 'CLONE_NEWNET' undeclared (first use in this function)
zebra/zebra_ns_notify.c:128: error: (Each undeclared identifier is reported only once
zebra/zebra_ns_notify.c:128: error: for each function it appears in.)
zebra/zebra_ns_notify.c:140: warning: implicit declaration of function 'basename'

FreeBSD9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI004BUILD/config.status/config.status

OmniOS amd64 build: Failed

Make failed for OmniOS amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI010BUILD/ErrorLog/log_make.txt)

              ^
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: fatal error: sys/inotify.h: No such file or directory
compilation terminated.
Makefile:3573: recipe for target 'zebra/zebra_ns_notify.o' failed
make[2]: Leaving directory '/export/home/ci/cibuild.2310/frr-source'
make[2]: *** [zebra/zebra_ns_notify.o] Error 1
Makefile:4239: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/export/home/ci/cibuild.2310/frr-source'

OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI010BUILD/config.status/config.status

CentOS7 amd64 build: Failed

Configure failed for CentOS7 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI005BUILD/ErrorLog/log_configure.txt)

checking for python3-config... no
checking for python-config... python-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS7 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI005BUILD/config.log/config.log

Debian9 amd64 build: Failed

Configure failed for Debian9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI021BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Debian9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI021BUILD/config.log/config.log

OpenBSD60 amd64 build: Failed

Make failed for OpenBSD60 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI011BUILD/ErrorLog/log_make.txt)

zebra/zserv.c:200: warning: passing argument 2 of 'strncpy' makes pointer from integer without a cast
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: error: sys/inotify.h: No such file or directory
zebra/zebra_ns_notify.c: In function 'zebra_ns_ready_read':
zebra/zebra_ns_notify.c:128: warning: implicit declaration of function 'setns'
zebra/zebra_ns_notify.c:128: error: 'CLONE_NEWNET' undeclared (first use in this function)
zebra/zebra_ns_notify.c:128: error: (Each undeclared identifier is reported only once
zebra/zebra_ns_notify.c:128: error: for each function it appears in.)
zebra/zebra_ns_notify.c:140: warning: implicit declaration of function 'basename'

OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI011BUILD/config.status/config.status

Ubuntu1204 amd64 build: Failed

Configure failed for Ubuntu1204 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI002BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1204 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI002BUILD/config.log/config.log

FreeBSD10 amd64 build: Failed

Make failed for FreeBSD10 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI003BUILD/ErrorLog/log_make.txt)

       ^~~~~~~
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: fatal error: sys/inotify.h: No such file or directory
 #include <sys/inotify.h>
                         ^
compilation terminated.
*** Error code 1
Stop.
make[2]: stopped in /usr/home/ci/cibuild.2310/frr-source

FreeBSD10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI003BUILD/config.status/config.status

NetBSD7 amd64 build: Failed

Make failed for NetBSD7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI012BUILD/ErrorLog/log_make.txt)

       ^
  CC       zebra/zebra_ns_notify.o
zebra/zebra_ns_notify.c:31:25: fatal error: sys/inotify.h: No such file or directory
 #include <sys/inotify.h>
                         ^
compilation terminated.
*** Error code 1
Stop.
make[2]: stopped in /home/ci/cibuild.2310/frr-source

NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI012BUILD/config.status/config.status

Fedora24 amd64 build: Failed

Configure failed for Fedora24 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI015BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Fedora24 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2310/artifact/CI015BUILD/config.log/config.log

LabN-CI · 2018-01-12T16:33:14Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/1633 `a3da419` frr.github Build
Date	01/12/2018
Start	11:33:05
Finish	11:33:13
Run-Time	00:08
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2018-01-12-11:33:05.txt
Log	make-2018-01-12-11:33:05.out.bz2

For details, please contact louberger

qlyoung

cursory review for style

qlyoung · 2018-01-12T18:26:59Z

lib/zebra.h

@@ -486,7 +486,7 @@ typedef u_int16_t zebra_size_t;
 typedef u_int16_t zebra_command_t;

 /* VRF ID type. */
-typedef u_int16_t vrf_id_t;
+typedef u_int32_t vrf_id_t;


please use uint32_t, if the compiler doesn't complain at you for doing so ;)

qlyoung · 2018-01-12T18:29:32Z

zebra/main.c

+			vrf_with_netns = 1;
+#else
+			zlog_err(
+				 "Netns backend requested with vrf, whereas Netlink not available. Aborting");


I believe you can move the log message onto the same line as the fn call

qlyoung · 2018-01-12T18:30:27Z

zebra/zebra_ns.c

+	struct zebra_ns *zns = ns->info;
+
+	if (IS_ZEBRA_DEBUG_EVENT)
+		zlog_info ("ZNS %s with id %u (enabled)", ns->name, ns->ns_id);


no space after fn names

qlyoung · 2018-01-12T18:30:42Z

zebra/zebra_ns.c

+		zlog_info("ZNS %s with id %u (disabled)", ns->name, ns->ns_id);
+	if (!zns)
+		return 0;
+	return zebra_ns_disable (ns->ns_id, (void **)&zns);


no space after fn names

qlyoung · 2018-01-12T18:32:14Z

zebra/zebra_ns_notify.c

+ *
+ * Copyright (C) 2017 by 6WIND
+ *
+ * This file is part of FreeRangeRouting (FRR)


This is the wrong copyright header, please use the one listed in COMMUNITY.md (i.e. do not include FRR or This file is part of...)

qlyoung · 2018-01-12T18:33:34Z

zebra/zebra_ns_notify.h

+ *
+ * Copyright (C) 2017 by 6WIND
+ *
+ * This file is part of FreeRangeRouting (FRR)


Incorrect copyright header as before

donaldsharp · 2018-01-12T21:36:17Z

lib/ns.c

+{
+	if (have_netns()) {
+		/* Install NS commands. */
+		install_element (VRF_NODE, &ns_netns_cmd);


These should not be installed unless we have turned on namespaces as vrfs

donaldsharp · 2018-01-12T21:36:45Z

lib/ns.c

@@ -413,12 +433,21 @@ void ns_init(void)

 	if (have_netns()) {
 		/* Install NS commands. */
-		install_node(&ns_node, ns_config_write);
 		install_element(CONFIG_NODE, &ns_netns_cmd);


These should not be installed for use unless user specifies namespace as vrfs

LabN-CI · 2018-01-13T15:00:27Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/1633 `8b5d003` frr.github Build
Date	01/13/2018
Start	10:00:11
Finish	10:00:25
Run-Time	00:14
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2018-01-13-10:00:11.txt
Log	make-2018-01-13-10:00:11.out.bz2

For details, please contact louberger

NetDEF-CI · 2018-01-13T15:43:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

OmniOS amd64 build: Successful
NetBSD7 amd64 build: Successful
FreeBSD10 amd64 build: Successful
FreeBSD9 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
FreeBSD11 amd64 build: Successful
OpenBSD60 amd64 build: Successful
NetBSD6 amd64 build: Successful

Debian9 amd64 build: Failed

Configure failed for Debian9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI021BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Debian9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI021BUILD/config.log/config.log

Ubuntu1604 amd64 build: Failed

Package building failed for Ubuntu1604 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI014BUILD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI014BUILD/config.status/config.status

CentOS6 amd64 build: Failed

Configure failed for CentOS6 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI006BUILD/ErrorLog/log_configure.txt)

checking for PYTHON... no
checking for PYTHON... yes
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI006BUILD/config.log/config.log

Ubuntu1204 amd64 build: Failed

Configure failed for Ubuntu1204 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI002BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1204 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI002BUILD/config.log/config.log

Debian8 amd64 build: Failed

Package building failed for Debian8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI008BLD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI008BLD/config.status/config.status

Fedora24 amd64 build: Failed

Configure failed for Fedora24 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI015BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Fedora24 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI015BUILD/config.log/config.log

CentOS7 amd64 build: Failed

Configure failed for CentOS7 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI005BUILD/ErrorLog/log_configure.txt)

checking for python3-config... no
checking for python-config... python-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS7 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2315/artifact/CI005BUILD/config.log/config.log

pguibert6WIND · 2018-01-14T10:50:41Z

Hi @qlyoung , I made the changes requested.
initially, i was thinkning you would review #1587.
because i wanted to make it in two parts.

Hi @donaldsharp , I also made some changes accordingly.

NetDEF-CI · 2018-01-14T11:21:47Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Debian9 amd64 build: Successful
OmniOS amd64 build: Successful
NetBSD7 amd64 build: Successful
FreeBSD9 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
Debian8 amd64 build: Successful
FreeBSD11 amd64 build: Successful
OpenBSD60 amd64 build: Successful
NetBSD6 amd64 build: Successful
CentOS7 amd64 build: Successful

CentOS6 amd64 build: Failed

Configure failed for CentOS6 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI006BUILD/ErrorLog/log_configure.txt)

checking for PYTHON... no
checking for PYTHON... yes
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI006BUILD/config.log/config.log

Ubuntu1604 amd64 build: Failed

Configure failed for Ubuntu1604 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI014BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1604 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI014BUILD/config.log/config.log

Ubuntu1204 amd64 build: Failed

Configure failed for Ubuntu1204 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI002BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1204 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI002BUILD/config.log/config.log

Fedora24 amd64 build: Failed

Configure failed for Fedora24 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI015BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Fedora24 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2316/artifact/CI015BUILD/config.log/config.log

NetDEF-CI · 2018-01-15T13:07:50Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

FreeBSD9 amd64 build: Successful
OmniOS amd64 build: Successful
Ubuntu1204 amd64 build: Successful
NetBSD6 amd64 build: Successful
CentOS7 amd64 build: Successful
FreeBSD10 amd64 build: Successful
OpenBSD60 amd64 build: Successful
NetBSD7 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
FreeBSD11 amd64 build: Successful

CentOS6 amd64 build: Failed

Configure failed for CentOS6 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI006BUILD/ErrorLog/log_configure.txt)

checking for PYTHON... no
checking for PYTHON... yes
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

CentOS6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI006BUILD/config.log/config.log

Debian9 amd64 build: Failed

Configure failed for Debian9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI021BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Debian9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI021BUILD/config.log/config.log

Debian8 amd64 build: Failed

Debian8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI008BLD/config.log/config.log
Configure failed for Debian8 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI008BLD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1404 amd64 build: Failed

Configure failed for Ubuntu1404 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI001BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Ubuntu1404 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI001BUILD/config.log/config.log

Fedora24 amd64 build: Failed

Configure failed for Fedora24 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI015BUILD/ErrorLog/log_configure.txt)

checking for json_object_get in -ljson-c... yes
checking for python3-config... python3-config
checking whether we found a working Python version... yes
checking for LIBMNL_C... no
pkg-config did not find libmnl
configure: error: Linux Operating System chosen, but libmnl not found

Fedora24 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2319/artifact/CI015BUILD/config.log/config.log

NetDEF-CI · 2018-01-15T16:15:25Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

CentOS6 amd64 build: Successful
FreeBSD9 amd64 build: Successful
Debian9 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
OmniOS amd64 build: Successful
NetBSD6 amd64 build: Successful
CentOS7 amd64 build: Successful
Debian8 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
OpenBSD60 amd64 build: Successful
NetBSD7 amd64 build: Successful
Fedora24 amd64 build: Successful
FreeBSD11 amd64 build: Successful

Ubuntu1604 amd64 build: Failed

Package building failed for Ubuntu1604 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/CI014BUILD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \

Ubuntu1604 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/CI014BUILD/config.status/config.status

LabN-CI · 2018-01-16T01:16:19Z

🚧 Basic BGPD CI results: Partial FAILURE, 650 tests failed, has VALGRIND issues

Results table

_	_
Result	SUCCESS git merge/1633 `9c96862`
Date	01/15/2018
Start	16:24:13
Finish	20:16:15
Run-Time	03:52:02
Total	1625
Pass	975
Fail	650
Valgrind-Errors	0
Valgrind-Loss	2
Details	vncregress-2018-01-15-16:24:13.txt
Log	autoscript-2018-01-15-16:24:55.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-01-16T01:49:21Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Debian 9 deb pkg check: Successful
CentOS 6 rpm pkg check: Successful
Static analyzer (clang): Successful
Ubuntu 12.04 deb pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful

CentOS 7 rpm pkg check: Failed

CentOS 7 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt
CentOS 7 rpm pkg check: No useful log found

IPv4 protocols on Ubuntu 14.04: Failed

Fedora 24 rpm pkg check: Failed

Fedora 24 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/FEDORA24PKG/ErrorLog/log_package_start.txt
Fedora 24 rpm pkg check: No useful log found

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2320/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/TOPOU1604/ErrorLog/log_topotests.txt

IPv6 protocols on Ubuntu 14.04: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA b782607

New warnings:

Logic error: Dereference of null pointer in bgpd/bgp_network.c, function bgp_bind, line 482
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/shared/static_analysis/report-3b32df.html#EndPath

Static Analysis warning summary compared to base:

Fixed warnings: 0
New warnings: 1

22 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2320/artifact/shared/static_analysis/index.html

NetDEF-CI · 2018-01-16T07:54:23Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2324/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1204 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
Debian9 amd64 build: Successful
Debian8 amd64 build: Successful
OmniOS amd64 build: Successful
FreeBSD11 amd64 build: Successful
OpenBSD60 amd64 build: Successful
CentOS6 amd64 build: Successful
NetBSD6 amd64 build: Successful
NetBSD7 amd64 build: Successful
FreeBSD9 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
CentOS7 amd64 build: Successful

Fedora24 amd64 build: Failed

Make failed for Fedora24 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2324/artifact/CI015BUILD/ErrorLog/log_make.txt)

In file included from ./lib/zebra.h:138:0,
                 from pimd/pim_assert.c:20:
/usr/include/linux/in.h:28:3: error: redeclaration of enumerator IPPROTO_IP
   IPPROTO_IP = 0,  /* Dummy protocol for TCP  */
   ^
/usr/include/netinet/in.h:42:5: note: previous definition of IPPROTO_IP was here
     IPPROTO_IP = 0,    /* Dummy protocol for TCP.  */
     ^~~~~~~~~~
/usr/include/linux/in.h:30:3: error: redeclaration of enumerator IPPROTO_ICMP

Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2324/artifact/CI015BUILD/config.status/config.status

NetDEF-CI · 2018-01-16T08:59:29Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2325/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 16.04 deb pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
CentOS 6 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Static analyzer (clang): Successful

IPv6 protocols on Ubuntu 14.04: Failed

CentOS 7 rpm pkg check: Failed

CentOS 7 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2325/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt
CentOS 7 rpm pkg check: No useful log found

Fedora 24 rpm pkg check: Failed

Fedora 24 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2325/artifact/FEDORA24PKG/ErrorLog/log_package_start.txt
Fedora 24 rpm pkg check: No useful log found

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2325/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 OSPF6d StdErr Output:
% interface r1-eth4 not in (null)
2018/01/16 00:28:13 errors: OSPF6: ERROR: Command returned Warning Config Failed on config line 8: interface r1-eth4
r1 ISISd StdErr Output:

% interface r1-eth5 not in (null)
% interface r1-eth6 not in (null)
2018/01/16 00:28:12 errors: ISIS: ERROR: No such command on config line 6:  isis circuit-type level-2-only
Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
r1 failed SHOW ISIS INTERFACE DETAIL check:
--- actual SHOW ISIS INTERFACE DETAIL
+++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
@@ -1 +1,28 @@
 Area test:
+  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
+    Level-1 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.5.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:5::1/64
+
+  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
+    Level-2 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.6.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:6::1/64
2018-01-16 00:29:19,349 ERROR: assert failed at "test_all_protocol_startup/test_isis_interfaces": SHOW ISIS INTERFACE DETAIL failed for router r1:
  --- actual SHOW ISIS INTERFACE DETAIL
  +++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
  @@ -1 +1,28 @@
   Area test:
  +  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
  +    Level-1 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.5.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:5::1/64
  +
  +  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
  +    Level-2 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.6.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:6::1/64
assert 1 == 0
r1 failed SHOW IP BGP SUMMARY check:
--- actual SHOW IP BGP SUMMARY
+++ expected SHOW IP BGP SUMMARY
@@ -1,4 +1,4 @@
-BGP router identifier 192.168.0.1, local AS number 100 vrf-id 65535
+BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
 BGP table version 1
 RIB entries 1, using XXXX bytes of memory
 Peers 4, using XXXX KiB of memory
2018-01-16 00:29:19,519 ERROR: assert failed at "test_all_protocol_startup/test_bgp_summary": SHOW IP BGP SUMMARY failed for router r1:
  --- actual SHOW IP BGP SUMMARY
  +++ expected SHOW IP BGP SUMMARY
  @@ -1,4 +1,4 @@
  -BGP router identifier 192.168.0.1, local AS number 100 vrf-id 65535
  +BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
   BGP table version 1
   RIB entries 1, using XXXX bytes of memory
   Peers 4, using XXXX KiB of memory
assert 1 == 0
r1 failed SHOW BGP IPv6 SUMMARY check:
--- actual SHOW BGP IPv6 SUMMARY
+++ expected SHOW BGP IPv6 SUMMARY
@@ -1,4 +1,4 @@
-BGP router identifier 192.168.0.1, local AS number 100 vrf-id 65535
+BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
 BGP table version 1
 RIB entries 1, using XXXX bytes of memory
 Peers 4, using XXXX KiB of memory
2018-01-16 00:29:19,644 ERROR: assert failed at "test_all_protocol_startup/test_bgp_ipv6_summary": SHOW BGP IPv6 SUMMARY failed for router r1:
  --- actual SHOW BGP IPv6 SUMMARY
  +++ expected SHOW BGP IPv6 SUMMARY
  @@ -1,4 +1,4 @@
  -BGP router identifier 192.168.0.1, local AS number 100 vrf-id 65535
  +BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
   BGP table version 1
   RIB entries 1, using XXXX bytes of memory
   Peers 4, using XXXX KiB of memory
assert 1 == 0
2018-01-16 00:30:11,036 ERROR: assert failed at "test_bgp_ecmp_topo1/test_bgp_convergence": BGP router network did not converge
assert json["ipv4Unicast"]["vrfId"] value is different (
  --- Expected value
  +++ Current value
  @@ -1 +1 @@
  -0
  +65535)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2325/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2325/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA 3cd878d

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2325/artifact/shared/static_analysis/index.html

pguibert6WIND · 2018-01-16T10:35:50Z

default VRF value changes from 0 to 65535.
This is because in case vrf backend is NETNS, 0 is a valid value.

To keep consistency, the following will be tried:

the VRF_ID value for default will always be 0
in the case the NS_ID returned is 0, then a swap value will be elected : UINT16_MAX+1
( because UINT16_MAX is NS_UNKNOWN. so this will require to move ns_id_t from 16 bit to 32 bit.

NetDEF-CI · 2018-01-16T12:00:22Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2326/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1604 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
FreeBSD11 amd64 build: Successful
Debian8 amd64 build: Successful
CentOS6 amd64 build: Successful
NetBSD6 amd64 build: Successful
FreeBSD9 amd64 build: Successful
CentOS7 amd64 build: Successful
OmniOS amd64 build: Successful
Debian9 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
OpenBSD60 amd64 build: Successful
FreeBSD10 amd64 build: Successful
NetBSD7 amd64 build: Successful

Fedora24 amd64 build: Failed

Make failed for Fedora24 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2326/artifact/CI015BUILD/ErrorLog/log_make.txt)

In file included from ./lib/zebra.h:138:0,
                 from pimd/pim_assert.c:20:
/usr/include/linux/in.h:28:3: error: redeclaration of enumerator IPPROTO_IP
   IPPROTO_IP = 0,  /* Dummy protocol for TCP  */
   ^
/usr/include/netinet/in.h:42:5: note: previous definition of IPPROTO_IP was here
     IPPROTO_IP = 0,    /* Dummy protocol for TCP.  */
     ^~~~~~~~~~
/usr/include/linux/in.h:30:3: error: redeclaration of enumerator IPPROTO_ICMP

Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2326/artifact/CI015BUILD/config.status/config.status

NetDEF-CI · 2018-01-16T12:01:26Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2327/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Fedora24 amd64 build: Successful
FreeBSD11 amd64 build: Successful
NetBSD7 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
NetBSD6 amd64 build: Successful
CentOS7 amd64 build: Successful
Debian8 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Debian9 amd64 build: Successful
FreeBSD9 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
OmniOS amd64 build: Successful
Ubuntu1204 amd64 build: Successful
OpenBSD60 amd64 build: Successful

CentOS6 amd64 build: Failed

Make failed for CentOS6 amd64 build
see make log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2327/artifact/CI006BUILD/ErrorLog/log_make.txt
CentOS6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2327/artifact/CI006BUILD/config.status/config.status

NetDEF-CI · 2018-01-16T13:07:51Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
Ubuntu 16.04 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Debian 9 deb pkg check: Successful

Ubuntu 12.04 deb pkg check: Failed

Ubuntu 12.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/U1204DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 12.04 deb pkg check: No useful log found

IPv6 protocols on Ubuntu 14.04: Failed

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

Ubuntu 14.04 deb pkg check: Failed

Ubuntu 14.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 14.04 deb pkg check: No useful log found

IPv4 protocols on Ubuntu 14.04: Failed

Fedora 24 rpm pkg check: Failed

Fedora 24 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/FEDORA24PKG/ErrorLog/log_package_start.txt
Fedora 24 rpm pkg check: No useful log found

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2328/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 OSPF6d StdErr Output:
% interface r1-eth4 not in (null)
2018/01/16 04:47:52 errors: OSPF6: ERROR: Command returned Warning Config Failed on config line 8: interface r1-eth4
r1 ISISd StdErr Output:

% interface r1-eth5 not in (null)
% interface r1-eth6 not in (null)
2018/01/16 04:47:52 errors: ISIS: ERROR: No such command on config line 6:  isis circuit-type level-2-only
Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
r1 failed SHOW ISIS INTERFACE DETAIL check:
--- actual SHOW ISIS INTERFACE DETAIL
+++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
@@ -1 +1,28 @@
 Area test:
+  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
+    Level-1 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.5.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:5::1/64
+
+  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
+    Level-2 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.6.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:6::1/64
2018-01-16 04:48:58,552 ERROR: assert failed at "test_all_protocol_startup/test_isis_interfaces": SHOW ISIS INTERFACE DETAIL failed for router r1:
  --- actual SHOW ISIS INTERFACE DETAIL
  +++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
  @@ -1 +1,28 @@
   Area test:
  +  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
  +    Level-1 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.5.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:5::1/64
  +
  +  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
  +    Level-2 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.6.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:6::1/64
assert 1 == 0
2018-01-16 04:50:57,336 ERROR: ******************************************************************************
2018-01-16 04:50:57,336 ERROR: Test Target Summary                                                  Pass Fail
2018-01-16 04:50:57,336 ERROR: ******************************************************************************
2018-01-16 04:50:57,336 ERROR: 6    r3     See R1s address +10.28 secs                              0    1
2018-01-16 04:50:57,336 ERROR: ******************************************************************************
2018-01-16 04:50:57,337 ERROR: Total 49                                                             39   1
2018-01-16 04:50:57,337 ERROR: ******************************************************************************
2018-01-16 04:50:57,337 ERROR: See /tmp/topotests/bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/output.log for details of errors
2018-01-16 04:50:57,339 ERROR: assert failed at "bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/test_run_lu_tests": 1 tests failed
assert '1 tests failed' == 'See summary output above'
  - 1 tests failed
  + See summary output above

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/TOPOU1604/ErrorLog/log_topotests.txt

CentOS 7 rpm pkg check: Failed

CentOS 7 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt
CentOS 7 rpm pkg check: No useful log found

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA 3cd878d

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2328/artifact/shared/static_analysis/index.html

NetDEF-CI · 2018-01-16T13:33:42Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
Ubuntu 16.04 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Debian 9 deb pkg check: Successful

Ubuntu 12.04 deb pkg check: Failed

Ubuntu 12.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/U1204DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 12.04 deb pkg check: No useful log found

IPv6 protocols on Ubuntu 14.04: Failed

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

Ubuntu 14.04 deb pkg check: Failed

Ubuntu 14.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 14.04 deb pkg check: No useful log found

Fedora 24 rpm pkg check: Failed

Fedora 24 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/FEDORA24PKG/ErrorLog/log_package_start.txt
Fedora 24 rpm pkg check: No useful log found

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2330/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 OSPF6d StdErr Output:
% interface r1-eth4 not in (null)
2018/01/16 14:15:05 errors: OSPF6: ERROR: Command returned Warning Config Failed on config line 8: interface r1-eth4
r1 ISISd StdErr Output:

% interface r1-eth5 not in (null)
% interface r1-eth6 not in (null)
2018/01/16 14:15:05 errors: ISIS: ERROR: No such command on config line 6:  isis circuit-type level-2-only
Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
r1 failed SHOW ISIS INTERFACE DETAIL check:
--- actual SHOW ISIS INTERFACE DETAIL
+++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
@@ -1 +1,28 @@
 Area test:
+  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
+    Level-1 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.5.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:5::1/64
+
+  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
+    Level-2 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.6.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:6::1/64
2018-01-16 14:16:11,655 ERROR: assert failed at "test_all_protocol_startup/test_isis_interfaces": SHOW ISIS INTERFACE DETAIL failed for router r1:
  --- actual SHOW ISIS INTERFACE DETAIL
  +++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
  @@ -1 +1,28 @@
   Area test:
  +  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
  +    Level-1 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.5.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:5::1/64
  +
  +  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
  +    Level-2 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.6.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:6::1/64
assert 1 == 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/TOPOU1604/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 14.04: Failed

CentOS 7 rpm pkg check: Failed

CentOS 7 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt
CentOS 7 rpm pkg check: No useful log found

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA 21f8f34
Base image data for Git 21f8f34 does not exist - compare skipped

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2330/artifact/shared/static_analysis/index.html

NetDEF-CI · 2018-01-16T13:42:11Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
Ubuntu 16.04 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Debian 9 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful

Ubuntu 12.04 deb pkg check: Failed

Ubuntu 12.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/U1204DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 12.04 deb pkg check: No useful log found

IPv6 protocols on Ubuntu 14.04: Failed

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

Ubuntu 14.04 deb pkg check: Failed

Ubuntu 14.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 14.04 deb pkg check: No useful log found

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2329/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 OSPF6d StdErr Output:
% interface r1-eth4 not in (null)
2018/01/16 05:10:53 errors: OSPF6: ERROR: Command returned Warning Config Failed on config line 8: interface r1-eth4
r1 ISISd StdErr Output:

% interface r1-eth5 not in (null)
% interface r1-eth6 not in (null)
2018/01/16 05:10:53 errors: ISIS: ERROR: No such command on config line 6:  isis circuit-type level-2-only
Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
r1 failed SHOW ISIS INTERFACE DETAIL check:
--- actual SHOW ISIS INTERFACE DETAIL
+++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
@@ -1 +1,28 @@
 Area test:
+  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
+    Level-1 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.5.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:5::1/64
+
+  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
+    Level-2 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.6.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:6::1/64
2018-01-16 05:11:59,694 ERROR: assert failed at "test_all_protocol_startup/test_isis_interfaces": SHOW ISIS INTERFACE DETAIL failed for router r1:
  --- actual SHOW ISIS INTERFACE DETAIL
  +++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
  @@ -1 +1,28 @@
   Area test:
  +  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
  +    Level-1 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.5.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:5::1/64
  +
  +  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
  +    Level-2 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.6.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:6::1/64
assert 1 == 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Fedora 24 rpm pkg check: Failed

Fedora 24 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/FEDORA24PKG/ErrorLog/log_package_start.txt
Fedora 24 rpm pkg check: No useful log found

CentOS 7 rpm pkg check: Failed

CentOS 7 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt
CentOS 7 rpm pkg check: No useful log found

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA 3cd878d

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2329/artifact/shared/static_analysis/index.html

rwestphal · 2018-01-16T14:44:06Z

lib/ns.c

+	rt->rtgen_family = AF_UNSPEC;
+
+	mnl_attr_put_u32(nlh, NETNSA_FD, fd);
+	mnl_attr_put_u32(nlh, NETNSA_NSID, ns_id);


NETNSA_NSID was only introduced in the kernel by 2015. Will this VRF netns backend work on older kernel that don't have this capability?

a fallback mecahnism is put in place, so that NSID will be locally generated, and so that the VRFID will be local to frr.

NetDEF-CI · 2018-01-16T14:52:35Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
Ubuntu 16.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Debian 9 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful

Ubuntu 12.04 deb pkg check: Failed

Ubuntu 12.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/U1204DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 12.04 deb pkg check: No useful log found

CentOS 6 rpm pkg check: Failed

CentOS 6 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/CENTOS6PKG/ErrorLog/log_package_start.txt
CentOS 6 rpm pkg check: No useful log found

IPv6 protocols on Ubuntu 14.04: Failed

Fedora 24 rpm pkg check: Failed

Fedora 24 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/FEDORA24PKG/ErrorLog/log_package_start.txt
Fedora 24 rpm pkg check: No useful log found

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2331/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 OSPF6d StdErr Output:
% interface r1-eth4 not in (null)
2018/01/16 06:32:35 errors: OSPF6: ERROR: Command returned Warning Config Failed on config line 8: interface r1-eth4
r1 ISISd StdErr Output:

% interface r1-eth5 not in (null)
% interface r1-eth6 not in (null)
2018/01/16 06:32:35 errors: ISIS: ERROR: No such command on config line 6:  isis circuit-type level-2-only
Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
r1 failed SHOW ISIS INTERFACE DETAIL check:
--- actual SHOW ISIS INTERFACE DETAIL
+++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
@@ -1 +1,28 @@
 Area test:
+  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
+    Level-1 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.5.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:5::1/64
+
+  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
+    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
+    Level-2 Information:
+      Metric: 10, Active neighbors: 0
+      Hello interval: 3, Holddown count: 10 (pad)
+      CNSP interval: 10, PSNP interval: 2
+      LAN Priority: 64, is not DIS
+    IP Prefix(es):
+      192.168.6.1/26
+    IPv6 Link-Locals:
+      fe80::XXXX:XXXX:XXXX:XXXX/64
+    IPv6 Prefixes:
+      fc00:0:0:6::1/64
2018-01-16 06:33:42,226 ERROR: assert failed at "test_all_protocol_startup/test_isis_interfaces": SHOW ISIS INTERFACE DETAIL failed for router r1:
  --- actual SHOW ISIS INTERFACE DETAIL
  +++ expected SHOW ISIS OSPF6 INTERFACE DETAIL
  @@ -1 +1,28 @@
   Area test:
  +  Interface: r1-eth5, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L1, SNPA: XXXX.XXXX.XXXX
  +    Level-1 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.5.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:5::1/64
  +
  +  Interface: r1-eth6, State: Up, Active, Circuit Id: 0xXX
  +    Type: lan, Level: L2, SNPA: XXXX.XXXX.XXXX
  +    Level-2 Information:
  +      Metric: 10, Active neighbors: 0
  +      Hello interval: 3, Holddown count: 10 (pad)
  +      CNSP interval: 10, PSNP interval: 2
  +      LAN Priority: 64, is not DIS
  +    IP Prefix(es):
  +      192.168.6.1/26
  +    IPv6 Link-Locals:
  +      fe80::XXXX:XXXX:XXXX:XXXX/64
  +    IPv6 Prefixes:
  +      fc00:0:0:6::1/64
assert 1 == 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/TOPOU1604/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 14.04: Failed

Ubuntu 14.04 deb pkg check: Failed

Ubuntu 14.04 deb pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt
Ubuntu 14.04 deb pkg check: No useful log found

CentOS 7 rpm pkg check: Failed

CentOS 7 rpm pkg check: Unknown Log <log_package_start.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt
CentOS 7 rpm pkg check: No useful log found

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA 21f8f34

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2331/artifact/shared/static_analysis/index.html

LabN-CI · 2018-01-29T09:58:01Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1633 `3ced9d0`
Date	01/29/2018
Start	04:35:09
Finish	04:57:59
Run-Time	22:50
Total	1808
Pass	1808
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-01-29-04:35:09.txt
Log	autoscript-2018-01-29-04:35:48.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-01-29T10:27:36Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2425/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 1633, comparing to Git base SHA 08c9af9

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2425/artifact/shared/static_analysis/index.html

The netns backend is chosen by VRF if a runtime flag named vrfwnetns is selected when running zebra. In the case the NETNS backend is chosen, in some case the VRFID value is being assigned the value of the NSID. Within the perimeter of that work, this is why the vrf_lookup_by_table function is extended with a new parameter. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

a vty command is added: in addition to this command ( kept for future usage): - [no] logical-router-id <ID> netns <NETNSNAME> a new command is being placed under vrf subnode - vrf <NAME> [no] netns <NETNSNAME> exit This command permits to map a VRF with a Netnamespace. The commit only handles the relationship between vrf and ns structures. It adds 2 attributes to vrf structure: - one defines the kind of vrf ( mapped under netns or vrf from kernel) - the other is the opaque pointer to ns The show running-config is handled by zebra daemon. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Using the vrf backend kind, the vty command that configured netns under vty will not be installed if the vrf backend is vrf lite Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Upon following calls: interface poll, address poll, route poll, and ICMPv6 handling, each new Namespace is being parsed. For that, the socket operations need to switch from one NS to one other, to get the necessary information. As of now, there is a crash when dumping interfaces, through show running-config. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

For each route to be added or deleted, instead of applying directly to default namespaces, when a vrf is mapped to a namespace, then the correct zns must be found out. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

All ipv6 operations stick to namespace. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Using c-lang scan-build tool, fix a dereference of a null pointer. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

This commit is also a fix that avoids a VRF to be attached to the wrong namespace context, at creation time. Because the VRF, at creation time does not know yet the namespace where it will get its information. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

In addition to have the possibility to create from vty vrf based on a netns backend, the API will be made accessible from external, especially for zebra that will handle the netns discovery part. This commit is externalising following functions: - netns_pathname - ns_handler_create - vrf_handler_create Also, the VRF initialisation case when under NETNS backend is changed, since the NS identifier may not be known at the configuration time,but may be known later, under discovery process. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

If vrf backend is netns, then the zebra will create its own zebra_ns context for each new netns discovered. As consequence, a routing table, and other contexts will be created for each new namespace discovered. When it is enabled, a populate process will be done, consisting in learning new interfaces and routes, and addresses from other NETNS. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The zebra netnamespace contexts are initialised, based on the callback coming from the NS. Reversely, the list of ns is parsed to disable the ns contexts. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Show vrf command displays information on the vrf, if it is related to vrf kernel or if it is related to netns. When a vrf from kernel is detected, before creating a new vrf, a check is done against an already present vrf, and if that vrf is not a vrf mapped with a netns. If that is that case, then the creation is rejected. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The addition of the name of the netns in the vrf message introduces also a limitation when the size of the netns is bigger than 15 bytes. Then the netns are ignored by the library. In addition to this, some sanity checks have been introduced. some functions to create the netns from a call not coming from the vty is being added with traces. Also, the ns vty function is reentrant, if the context is already created. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Two apis are provided so that the switch from one netns to an other one is taken care. Also an other API to know if the VRF has a NETNS backend or a VRF Lite backend. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

A NS identifier is collected by netlink. This identifier is a 32 bit identifier that is either generated by the kernel (if not set) or manually set by a set netlink command. The commit here is getting the NSID from the newly created NS. If the linux option to create or get a new NSID from the kernel does not exist, then the NSID is locally genrated. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

upon zebra initialisation, and upon further netnamespace creation, the the netnamespaces are created and a vrf associated to the netnamespace is created. By convention, the name of the netns will be the same as the VRF. Add a stub routine that returns a fake ns identifier, in case netlink ( linux machines) is not available. Also, upon each newly discovered NETNS, a NSID id being generated, either by relying on kernel NSID feature, or by generating locally the NSID ( see previous commit for more information). Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

when the netns backend is selected for VRF, the default VRF is being assigned a NSID. This avoids the need to handle the case where if the incoming NSID was 0 for a non default VRF, then a specific handling had to be done to keep 0 value for default VRF. In most cases, as the first NETNS to get a NSID will be the default VRF, most probably the default VRF will be assigned to 0, while the other ones will have their value incremented. On some cases, where the NSID is already assigned for NETNS, including default VRF, then the default VRF value will be the one derived from the NSID of default VRF, thus keeping consistency between VRF IDs and NETNS IDs. Default NS is attempted to be created. Actually, some VMs may have the netns feature, but the NS initialisation fails because that folder is not present. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

this is a static analysis performed by c-lang scan-build tool that demonstrated this issue. This commit is handling the fix. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

For supporting vrf based on namespaces, it is possible that an interface with the same index is present. This is the case for loopback interfaces. For that, for each query, if the interface is not found , matching the vrf identifier, then a new interface is created, when the backens for VRF is NETNS. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

the vrf identifier in the ospf_vrf_enable routine is never read, then does not need to be initialised. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The assert appears in zebra_mpls.c when checking default zebra_vrf. It appears that when the mpls entries are flushed, it gets the default vrf which is already flushed by vrf_terminate() function. In order to avoid that assert to trigger a crash, the mpls flush is called before vrf termination. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The vrf_sockunion_socket() wraps sockunion_socket() with vrf_id as additional parameter. The creation of socket forces the user to transparently move to new NETNS for doing the operation. The vrf_getaddr_info() wraps getaddr_info() with vrf_id as additional parameter. That API relies on the underlying system. Then there may be need to switch to an other netns in that case too. Also, the vrf_socket() implementation is simplified. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The change contained in this commit does the following: - discovery of vrf id from zebra daemon, and adaptation of bgp contexts with BGP. The list of network addresses contain a reference to the bgp context supporting the vrf. The bgp context contains a vrf pointer that gives information about the netns path in case the vrf is a netns path. Only some contexts are impacted, namely socket creation, and retrieval of local IP settings. ( this requires vrf identifier). Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

NetDEF-CI · 2018-01-30T13:53:28Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

OmniOS amd64 build: Successful
Debian9 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
CentOS7 amd64 build: Successful
CentOS6 amd64 build: Successful
Ubuntu1404 amd64 build: Successful
Debian8 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
Fedora24 amd64 build: Successful

NetBSD7 amd64 build: Failed

DejaGNU Unittests (make check) failed for NetBSD7 amd64 build: (see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI012BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
______ TestCapability.test_DynCap_Dynamic_Capability_Message_IP_Multicast ______
self = <test_capability.TestCapability object at 0x7f7ff4e6b290>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_capability.TestCapability object at 0x7f7ff4e6b290>
line = 'DynCap: Dynamic Capability Message, IP/Multicast'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'DynCap: Dynamic Capability Message, IP/Multicast' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
__________ TestCapability.test_dyn_empty_Dynamic_capability_but_empty __________
self = <test_capability.TestCapability object at 0x7f7ff4ac0810>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_capability.TestCapability object at 0x7f7ff4e6b290>
line = 'dyn-empty: Dynamic capability, but empty.'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'dyn-empty: Dynamic capability, but empty.' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
_________ TestCapability.test_ORF_ORF_simple_single_entry_single_tuple _________
self = <test_capability.TestCapability object at 0x7f7ff4af50d0>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_capability.TestCapability object at 0x7f7ff4e6b290>
line = 'ORF: ORF, simple, single entry, single tuple'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'ORF: ORF, simple, single entry, single tuple' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
________________ TestCapability.test_padded_valid_with_padding _________________
self = <test_capability.TestCapability object at 0x7f7ff4ac0f10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI012BUILD/config.status/config.status

FreeBSD10 amd64 build: Failed

DejaGNU Unittests (make check) failed for FreeBSD10 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI003BUILD/ErrorLog/log_pytests.txt
FreeBSD10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI003BUILD/config.status/config.status

FreeBSD9 amd64 build: Failed

DejaGNU Unittests (make check) failed for FreeBSD9 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI004BUILD/ErrorLog/log_pytests.txt
FreeBSD9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI004BUILD/config.status/config.status

OpenBSD60 amd64 build: Failed

DejaGNU Unittests (make check) failed for OpenBSD60 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI011BUILD/ErrorLog/log_pytests.txt
OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI011BUILD/config.status/config.status

FreeBSD11 amd64 build: Failed

DejaGNU Unittests (make check) failed for FreeBSD11 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI009BUILD/ErrorLog/log_pytests.txt
FreeBSD11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI009BUILD/config.status/config.status

NetBSD6 amd64 build: Failed

DejaGNU Unittests (make check) failed for NetBSD6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI007BUILD/ErrorLog/log_pytests.txt
NetBSD6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2441/artifact/CI007BUILD/config.status/config.status

LabN-CI · 2018-01-30T14:13:01Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1633 `92f3afb`
Date	01/30/2018
Start	08:50:10
Finish	09:12:59
Run-Time	22:49
Total	1805
Pass	1805
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-01-30-08:50:10.txt
Log	autoscript-2018-01-30-08:50:46.log.bz2

For details, please contact louberger

pguibert6WIND · 2018-02-02T07:44:54Z

closing ( replaced with #1662 )

qlyoung reviewed Jan 12, 2018

View reviewed changes

donaldsharp reviewed Jan 12, 2018

View reviewed changes

pguibert6WIND force-pushed the issue_385_step3 branch from da1fc96 to f6cd156 Compare January 15, 2018 12:31

pguibert6WIND force-pushed the issue_385_step3 branch from 9c96862 to 573774c Compare January 16, 2018 07:35

pguibert6WIND force-pushed the issue_385_step3 branch from 573774c to 7d652d0 Compare January 16, 2018 08:10

pguibert6WIND force-pushed the issue_385_step3 branch from 7d652d0 to 1ed4e57 Compare January 16, 2018 11:38

pguibert6WIND force-pushed the issue_385_step3 branch from 687233c to c168952 Compare January 16, 2018 12:55

rwestphal reviewed Jan 16, 2018

View reviewed changes

FRRouting deleted a comment from LabN-CI Jan 16, 2018

pguibert6WIND added 8 commits January 29, 2018 18:01

lib: netns vty command not available when vrf backend is vrf lite

5aa276f

Using the vrf backend kind, the vty command that configured netns under vty will not be installed if the vrf backend is vrf lite Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

zebra: ipv6 operations stick to namespace

a8297ee

All ipv6 operations stick to namespace. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

zebra: fix static analysis issue with zvrf_id

be04e56

Using c-lang scan-build tool, fix a dereference of a null pointer. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND force-pushed the issue_385_step3 branch from 3ced9d0 to 92f3afb Compare January 30, 2018 13:34

pguibert6WIND added 15 commits January 30, 2018 14:52

zebra: handle the zns init/destroy

7b417a5

The zebra netnamespace contexts are initialised, based on the callback coming from the NS. Reversely, the list of ns is parsed to disable the ns contexts. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

lib: provide an API to switch from one netns to an other

64626d0

Two apis are provided so that the switch from one netns to an other one is taken care. Also an other API to know if the VRF has a NETNS backend or a VRF Lite backend. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

zebra: fix initialised vrf_id value never read

f01aa3c

this is a static analysis performed by c-lang scan-build tool that demonstrated this issue. This commit is handling the fix. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

ospfd: fix static analysis with variable initialised never read

90ad55b

the vrf identifier in the ospf_vrf_enable routine is never read, then does not need to be initialised. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND closed this Feb 2, 2018

Netns Support / framework for supporting vrf with netns backend #1633

Netns Support / framework for supporting vrf with netns backend #1633

Conversation

pguibert6WIND commented Jan 12, 2018

NetDEF-CI commented Jan 12, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1604 amd64 build: Failed

Ubuntu1404 amd64 build: Failed

FreeBSD11 amd64 build: Failed

Debian8 amd64 build: Failed

CentOS6 amd64 build: Failed

NetBSD6 amd64 build: Failed

FreeBSD9 amd64 build: Failed

OmniOS amd64 build: Failed

CentOS7 amd64 build: Failed

Debian9 amd64 build: Failed

OpenBSD60 amd64 build: Failed

Ubuntu1204 amd64 build: Failed

FreeBSD10 amd64 build: Failed

NetBSD7 amd64 build: Failed

Fedora24 amd64 build: Failed

LabN-CI commented Jan 12, 2018

🛑 Basic BGPD CI results: FAILURE

qlyoung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LabN-CI commented Jan 13, 2018

🛑 Basic BGPD CI results: FAILURE

NetDEF-CI commented Jan 13, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Debian9 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

CentOS6 amd64 build: Failed

Ubuntu1204 amd64 build: Failed

Debian8 amd64 build: Failed

Fedora24 amd64 build: Failed

CentOS7 amd64 build: Failed

pguibert6WIND commented Jan 14, 2018

NetDEF-CI commented Jan 14, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

CentOS6 amd64 build: Failed

Ubuntu1604 amd64 build: Failed

Ubuntu1204 amd64 build: Failed

Fedora24 amd64 build: Failed

NetDEF-CI commented Jan 15, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

CentOS6 amd64 build: Failed

Debian9 amd64 build: Failed

Debian8 amd64 build: Failed

Ubuntu1404 amd64 build: Failed

Fedora24 amd64 build: Failed

NetDEF-CI commented Jan 15, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Ubuntu1604 amd64 build: Failed

LabN-CI commented Jan 16, 2018

🚧 Basic BGPD CI results: Partial FAILURE, 650 tests failed, has VALGRIND issues

NetDEF-CI commented Jan 16, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed

IPv4 protocols on Ubuntu 14.04: Failed