lib: add flag to have libyang load internal ietf-yang-library module #17015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mgmtd makes use of libyang's internal ietf-yang-library module to add support for said module to FRR management. Previously, mgmtd was loading this module explicitly; however, that required that libyang's `ietf-yang-library.yang` module definition file be co-located with FRR's yang files so that it (and ietf-datastore.yang) would be found when searched for by libyang using FRRs search path. This isn't always the case depending on how the user compiles and installs libyang so mgmtd was failing to run in some cases. Instead of doing it the above way we simply tell libyang to load it's internal version of ietf-yang-library when we initialize the libyang context. This required adding a boolean to a couple of the init functions which is why so many files are touched (although all the changes are minimal). Signed-off-by: Christian Hopps <chopps@labn.net>
choppsv1
force-pushed
the
chopps/load-internal-ietf-yang-library
branch
from
2e5b762
to
e8648a0
Compare
idryzhov
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mgmtd makes use of libyang's internal ietf-yang-library module to add support for said module to FRR management. Previously, ietf-yang-library was loading this module explicitly; however, that required that libyang's
ietf-yang-library.yangmodule definition file be co-located with FRR's so that it (and ietf-datastore.yang) would be found when searched for by libyang. This isn't always the case depending on how the user compiles and installs libyang so mgmtd was failing to run in these cases.Instead of doing it that way we simply tell libyang to load it's internal version of ietf-yang-library when we initialize the libyang context.
This required adding a boolean to a couple of the init functions which is why so many files are touched (although all the changes are minimal).