lib: Don't use malloc! #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread.c was using malloc. This was found by the assert added to memory.c. Fixes issues FRRouting#170 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
qlyoung
approved these changes
Feb 6, 2017
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-219/ This is a comment from an EXPERIMENTAL automated CI system. |
rwestphal
approved these changes
Feb 6, 2017
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-221/ This is a comment from an EXPERIMENTAL automated CI system. |
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Jun 24, 2021
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Jun 24, 2021
When VNI configuration is performed using VLAN-VNI mapping (i.e., without individual VXLAN interfaces) and flooded traffic is handled via multicast, the multicast group corresponding to the VNI needs to be explicitly read from the bridge FDB. This is relevant in the case of netlink interface to the kernel and for the scenario where a new VNI is provisioned or comes up. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2603831 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
eqvinox
pushed a commit
to opensourcerouting/frr
that referenced
this pull request
Nov 15, 2021
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Dec 7, 2022
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Dec 7, 2022
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 3, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 3, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 4, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 7, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 7, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 7, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 8, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 8, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 8, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 9, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 9, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
sworleys
pushed a commit
to sworleys/frr
that referenced
this pull request
Feb 9, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 10, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
sworleys
pushed a commit
to sworleys/frr
that referenced
this pull request
Feb 13, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170) Signed-off-by: Stephen Worley <sworley@nvidia.com>
sworleys
pushed a commit
to sworleys/frr
that referenced
this pull request
Feb 13, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170) Signed-off-by: Stephen Worley <sworley@nvidia.com>
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 15, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 15, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 17, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 23, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 24, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 27, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Feb 27, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Mar 8, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Mar 14, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Mar 20, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Mar 21, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Mar 27, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
donaldsharp
pushed a commit
to donaldsharp/frr
that referenced
this pull request
Mar 31, 2023
When the VLAN-VNI mapping is configured via a map and not using individual VXLAN interfaces, upon removal of a VNI ensure that the remote FDB entries are uninstalled correctly. Signed-off-by: Vivek Venkatraman <vivek@nvidia.com> Ticket: #2613048 Reviewed By: Testing Done: 1. Manual verification - logs in the ticket 2. Precommit (user job FRRouting#171) and evpn-min (user job FRRouting#170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread.c was using malloc. This was found by the
assert added to memory.c.
Fixes issues #170
Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com