Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nhrpd: fix passphrase handling, add topotest for resolution request #17115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nhrpd: fix passphrase handling, add topotest for resolution request #17115

wants to merge 2 commits into from

Commits on Oct 29, 2024

  1. nhrpd: Add topotest for retrying resolution request 

    Modified nhrp_topo topotest to test for newly added resolution
request retry feature. Changes to the topotest include adding a spoke to the
existing nhrp_topo topotest so that a topology with two spokes and hub
can be used to create shortcuts and test the sending/resending of
resolution requests and responses between spoke and hub. The resolution
request retry feature was tested by blocking incoming resolution requests on a
receiving nodes to stop the creation of a successful shortcut - which
then triggered the sending spoke to retry sending resolution requests

Signed-off-by: Joshua Muthii <jmuthii@labn.net>
    @jmuthiilabn
    jmuthiilabn committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d599aa1 View commit details
    Browse the repository at this point in the history

  2. nhrpd: Modify NHRP authentication feature logging 

    Modified nhrp_connection_authorized(). Initially, when writing debug
information about incoming NHRP packets with authentication enabled,
the nhrp_connection_authorized() function would print the
passphrase of the incoming packet as if it were a null terminated
string. This meant that if the passphrase on the incoming packet
had non ASCII-complient bytes in it, it would attempt to print those
bytes anyway. There was also no check that the size of the passphrase in
the incoming packet matched the size of the passphrase on the interface.
The changes in this commit log the passphrase on the incoming packet as
well as the passphrase on interface in HEX to avoid issues with ASCII.
It also performs a check that accounts for the sizes of the two different
passphrases

Moved CISCO_PASS_LENGTH_LEN from nhrp_vty.c to nhrp_protocol.h
for easier access  to the macro in other files

Signed-off-by: Joshua Muthii <jmuthii@labn.net>
    @jmuthiilabn
    jmuthiilabn committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    5718ee3 View commit details
    Browse the repository at this point in the history