bgpd: fix uninitialized bgp_labels #17191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory was not zeroed at allocation. > ==2604268== Conditional jump or move depends on uninitialised value(s) > ==2604268== at 0x26F026: bgp_labels_unintern (bgp_label.c:116) > ==2604268== by 0x30000C: adj_free (bgp_updgrp_adv.c:81) > ==2604268== by 0x3019EE: bgp_adj_out_remove_subgroup (bgp_updgrp_adv.c:728) > ==2604268== by 0x30537C: subgroup_withdraw_packet (bgp_updgrp_packet.c:1042) > ==2604268== by 0x2970AF: bgp_generate_updgrp_packets (bgp_packet.c:508) > ==2604268== by 0x49E06F1: event_call (event.c:2001) > ==2604268== by 0x495AB8B: frr_run (libfrr.c:1238) > ==2604268== by 0x200C4B: main (bgp_main.c:555) Fixes: 3c86f77 ("bgpd: add bgp_labels hash") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
louis-6wind
force-pushed
the
fix-bgp-labels
branch
from
f940f8d
to
ba7211d
Compare
|
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
|
@louis-6wind could you fix frrbot styling? |
Fix uninitialized labels that cause multiple valgrind issues. > ==3729602== Use of uninitialised value of size 8 > ==3729602== at 0x492B493: hash_get (hash.c:140) > ==3729602== by 0x2629D2: bgp_labels_intern (bgp_label.c:98) > ==3729602== by 0x2E6C92: bgp_adj_out_set_subgroup (bgp_updgrp_adv.c:622) > ==3729602== by 0x2A6810: subgroup_process_announce_selected (bgp_route.c:3340) > ==3729602== by 0x2E5FF6: group_announce_route_walkcb (bgp_updgrp_adv.c:260) > ==3729602== by 0x2E3E28: update_group_walkcb (bgp_updgrp.c:1759) > ==3729602== by 0x492B9A0: hash_walk (hash.c:270) > ==3729602== by 0x2E498C: update_group_af_walk (bgp_updgrp.c:2090) > ==3729602== by 0x2E7C0D: group_announce_route (bgp_updgrp_adv.c:1119) > ==3729602== by 0x2A796E: bgp_process_main_one (bgp_route.c:3865) > ==3729602== by 0x2A808A: bgp_process_wq (bgp_route.c:3991) > ==3729602== by 0x49CC7CF: work_queue_run (workqueue.c:282) > ==3729602== by 0x49BBF25: event_call (event.c:2019) > ==3729602== by 0x49413CA: frr_run (libfrr.c:1238) > ==3729602== by 0x1FD1D3: main (bgp_main.c:555) > ==2604268== Use of uninitialised value of size 8 > ==2604268== at 0x4943016: hash_get (hash.c:159) > ==2604268== by 0x26EFC1: bgp_labels_intern (bgp_label.c:97) > ==2604268== by 0x28077B: leak_update (bgp_mplsvpn.c:1298) > ==2604268== by 0x2824A3: vpn_leak_from_vrf_update (bgp_mplsvpn.c:1932) > ==2604268== by 0x2C281C: bgp_static_update (bgp_route.c:6974) > ==2604268== by 0x2C366F: bgp_static_set (bgp_route.c:7263) > ==2604268== by 0x2C435B: bgp_network_magic (bgp_route.c:7556) > ==2604268== by 0x2ACF09: bgp_network (bgp_route_clippy.c:86) > ==2604268== by 0x4914EE7: cmd_execute_command_real (command.c:1003) > ==2604268== by 0x4915060: cmd_execute_command (command.c:1062) > ==2604268== by 0x4915610: cmd_execute (command.c:1228) > ==2604268== by 0x49E7C32: vty_command (vty.c:625) > ==2604268== by 0x49E9B56: vty_execute (vty.c:1388) > ==2604268== by 0x49EC331: vtysh_read (vty.c:2400) > ==2604268== by 0x49E06F1: event_call (event.c:2001) > ==2604268== by 0x495AB8B: frr_run (libfrr.c:1238) > ==2604268== by 0x200C4B: main (bgp_main.c:555) Fixes: ddb5b48 ("bgpd: vpn-vrf route leaking") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
louis-6wind
force-pushed
the
fix-bgp-labels
branch
from
ba7211d
to
3225b77
Compare
done |
|
ci:rerun |
This was referenced Oct 24, 2024
Jafaral
added a commit
that referenced
this pull request
Oct 24, 2024
bgpd: fix uninitialized bgp_labels (backport #17191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for valgrind issues in #17144
Closes #17144