tests: logger masked in topotest.py (backport #17157) #17277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
a local logger masks the global logger and prevents errors from being gracefully handled within topotest.py Signed-off-by: Liam Brady <lbrady@labn.net> (cherry picked from commit 1b38f33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where
sysctl_assure()orsysctl_atleast()catch an error, the previous declaration of the local variableloggermasks the global variable also calledloggerand prevents the error from being gracefully handled. Instead, the local logger is referenced before assignment which throws an unhandled error. The name of the local logger is changed to avoid this unintended behavior.This is an automatic backport of pull request #17157 done by Mergify.