Remove event master free unused #17280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call was originally put into place to help reduce memory problems associated with bgp having a bajillion events under load and then we would have a bunch of events ready to be used on the unused list. In the meantime code was put into place that limited the depth of the unused list to 10 elements. This call has now become unnecessary. Let's just remove it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
The `alloc` counter was tracking the current active number of events in the system and if it went to 0 when freeing a new one it would assert. This assert is a duplicate of what would happen with the XFREE in the same situation. As such it is not necessary. Also remove the `event_master_free_unused` function from the system. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ton31337
reviewed
Oct 29, 2024
| @@ -85,7 +85,7 @@ struct event_loop { | |||
| int io_pipe[2]; | |||
| int fd_limit; | |||
| struct fd_handler handler; | |||
| unsigned long alloc; | |||
| //unsigned long alloc; | |||
ton31337
reviewed
Oct 29, 2024
| @@ -4223,8 +4223,6 @@ int bgp_delete(struct bgp *bgp) | |||
| if (bgp->process_queue) | |||
| work_queue_free_and_null(&bgp->process_queue); | |||
|
|
|||
| event_master_free_unused(bm->master); | |||
There was a problem hiding this comment.
Shouldn't this be merged to the same commit e94952f?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.