Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix blank line in running-config with bmp listener cmd (backport #17278) #17285

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 29, 2024

An extra blank line is added in show running-config with BMP:

ubuntu2204hwe(config)# router bgp 65500
ubuntu2204hwe(config-router)# bmp targets tgt
ubuntu2204hwe(config-bgp-bmp)# bmp monitor ipv4 unicast pre-policy
ubuntu2204hwe(config-bgp-bmp)# bmp listener 192.0.2.100 port 44
ubuntu2204hwe(config-bgp-bmp)# do show running-config

router bgp 65500
[..]
bmp targets tgt
bmp monitor ipv4 unicast pre-policy
<-- blank line
bmp listener 192.0.2.100 port 44
exit

Remove the blank line.

Fixes: ed18356 ("bgpd/bmp: BMP implementation")


This is an automatic backport of pull request #17278 done by Mergify.

An extra blank line is added in show running-config with BMP:

> ubuntu2204hwe(config)# router bgp 65500
> ubuntu2204hwe(config-router)# bmp targets tgt
> ubuntu2204hwe(config-bgp-bmp)# bmp monitor ipv4 unicast pre-policy
> ubuntu2204hwe(config-bgp-bmp)# bmp listener 192.0.2.100 port 44
> ubuntu2204hwe(config-bgp-bmp)# do show running-config
>
> router bgp 65500
> [..]
>  bmp targets tgt
>   bmp monitor ipv4 unicast pre-policy
>                                       <-- blank line
>   bmp listener 192.0.2.100 port 44
>  exit

Remove the blank line.

Fixes: ed18356 ("bgpd/bmp: BMP implementation")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
(cherry picked from commit 9a33ee1)
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit ecc5ff8 into stable/9.1 Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants