Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(10.0 backport) bgpd: add bgp ipv6-auto-ra command #17288

Merged
merged 1 commit into from
Oct 29, 2024

bgpd: add `bgp ipv6-auto-ra` command

44bf223
Select commit
Loading
Failed to load commit list.
Merged

(10.0 backport) bgpd: add bgp ipv6-auto-ra command #17288

bgpd: add `bgp ipv6-auto-ra` command
44bf223
Select commit
Loading
Failed to load commit list.
frrbot / frrbot completed Oct 29, 2024 in 7s

Style and/or linter errors found

Style and/or linter errors found

Details

Thanks for your contribution to FRR!

Click for style suggestions

diff --git a/bgpd/bgp_nht.c b/bgpd/bgp_nht.c
index 572c8ed32..1044bc065 100644
--- a/bgpd/bgp_nht.c
+++ b/bgpd/bgp_nht.c
@@ -637,8 +637,7 @@ static void bgp_process_nexthop_update(struct bgp_nexthop_cache *bnc,
 			 */
 			if (peer && !peer->ifp &&
 			    CHECK_FLAG(peer->flags, PEER_FLAG_CAPABILITY_ENHE) &&
-			    !CHECK_FLAG(bnc->bgp->flags,
-					BGP_FLAG_IPV6_NO_AUTO_RA) &&
+			    !CHECK_FLAG(bnc->bgp->flags, BGP_FLAG_IPV6_NO_AUTO_RA) &&
 			    nhr->prefix.family == AF_INET6 &&
 			    nexthop->type != NEXTHOP_TYPE_BLACKHOLE) {
 				struct interface *ifp;
diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
index eb4a8100a..7068225af 100644
--- a/bgpd/bgp_vty.c
+++ b/bgpd/bgp_vty.c
@@ -4859,12 +4859,8 @@ DEFUN(no_bgp_fast_convergence, no_bgp_fast_convergence_cmd,
 	return CMD_SUCCESS;
 }
 
-DEFPY (bgp_ipv6_auto_ra,
-       bgp_ipv6_auto_ra_cmd,
-       "[no] bgp ipv6-auto-ra",
-       NO_STR
-       BGP_STR
-       "Allow enabling IPv6 ND RA sending\n")
+DEFPY(bgp_ipv6_auto_ra, bgp_ipv6_auto_ra_cmd, "[no] bgp ipv6-auto-ra",
+      NO_STR BGP_STR "Allow enabling IPv6 ND RA sending\n")
 {
 	if (vty->node == CONFIG_NODE) {
 		struct listnode *node, *nnode;

To apply the style suggestions:

curl https://gist.githubusercontent.com/polychaeta/7d4c5e0deedb9cc6709ddac41c44d013/raw/8807c5a643b59df48bb21456d3fdf7afa6c3e18e/style.diff | git apply -

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.