Support bgp l3vpn over srv6 te policy

[guoguojia2021]

Add SID list support IPv6 address.

router2(config-sr-te)# segment-list test_srv6
router2(config-sr-te-segment-list)# index 10 ipv6-address
X:X::X:X IPv6 address
router2(config-sr-te-segment-list)# index 10 ipv6-address 100:1::1
router2(config-sr-te-segment-list)# index 20 ipv6-address 200:1::1
router2(config-sr-te-segment-list)# index 30 mpls label
(16-1048575) Label Value
router2(config-sr-te-segment-list)# index 30 mpls label 100
% Configuration failed.

Error type: validation
Error description: The Segment List(test_srv6) Type must be SRv6!
router2(config-sr-te-segment-list)#
router2(config-sr-te)# segment-list test_mpls
router2(config-sr-te-segment-list)# index 10 mpls label 100
router2(config-sr-te-segment-list)# index 20 mpls label 200
router2(config-sr-te-segment-list)# index 30 ipv6-address 1:1::1
% Configuration failed.

Error type: validation
Error description: The Segment List(test_mpls) Type must be MPLS!
router2(config-sr-te-segment-list)#

router2# configure
router2(config)# seg
router2(config-sr)# traffic-eng
router2(config-sr-te)# policy color 100 endpoint
A.B.C.D SR Policy endpoint IPv4 address
X:X::X:X SR Policy endpoint IPv6 address
router2(config-sr-te)# policy color 100 endpoint 1.1.1.1

router2(config-sr-te)# policy color 100 endpoint 1.1.1.1
router2(config-sr-te-policy)# candidate-path preference 1 name mpls explicit segment-list test_mpls

router2(config-sr-te-policy)# candidate-path preference 1 name mpls explicit segment-list test_mpls
router2(config-sr-te-policy)# candidate-path preference 2 name srv6 explicit segment-list test_srv6
% Configuration failed.

Error type: validation
Error description: The Segment List type(2) and Policy type(1) must match!
router2(config-sr-te-policy)# exit
router2(config-sr-te)# policy color 200 endpoint 1:1::1
router2(config-sr-te-policy)# candidate-path preference 1 name srv6 explicit segment-list test_srv6
router2(config-sr-te-policy)# candidate-path preference 2 name mpls explicit segment-list test_mpls
% Configuration failed.

Error type: validation
Error description: The Segment List type(1) and Policy type(2) must match!

BGP L3vpn over SRv6-TE policy
config:

segment-routing
traffic-eng
segment-list a
index 10 ipv6-address 100:1::100
index 20 ipv6-address 200:1::200
exit
policy color 100 endpoint 1::1
candidate-path preference 1 name a explicit segment-list a
exit
exit
exit
!
end

show:
router2# show sr-te policy detail

Endpoint: 1::1 Color: 100 Name: BSID: - Status: Active Type: SRV6

• Preference: 1 Name: a Type: explicit Segment-List: a Protocol-Origin: Local

router2# show bgp ipv4 vpn
BGP table version is 2, local router ID is 2.2.2.2, vrf id 0
Default local pref 100, local AS 2
Route Distinguisher: 1:1
*> 192.168.11.0/24 1::1 0 0 1 ?
UN=1::1 EC{1:1 Color:01:100} label=16 sid=2001:db8:1:1:: sid_structure=[40,24,16,0] type=bgp, subtype=0
*> 192.168.15.0/24 1::1 0 0 1 ?
UN=1::1 EC{1:1 Color:01:100} label=16 sid=2001:db8:1:1:: sid_structure=[40,24,16,0] type=bgp, subtype=0

Displayed 2 routes and 2 total paths
router2# show bgp ipv4 vpn 192.168.11.0
BGP routing table entry for 1:1:192.168.11.0/24, version 1
not allocated
Paths: (1 available, best #1)
Advertised to non peer-group peers:
1::1
1
0.0.0.0 (metric 1024) from 1::1 (1.1.1.1)
Origin incomplete, metric 0, valid, external, best (First path received)
Relay-Nexthop(ip): gate 3fff:172:20:20::1, if eth0,
Relay-Nexthop(tunnel): srv6-tunnel:1::1|100(endpoint|color),
Extended Community: RT:1:1 Color:01:100
Remote label: 16
Remote SID: 2001:db8:1:1::
Last update: Sat Dec 7 04:27:16 2024
router2# show ip route vrf Vrf1 192.168.11.0
Routing entry for 192.168.11.0/24
Known via "bgp", distance 20, metric 0, vrf Vrf1, best
Last update 00:01:31 ago
_**1::1(vrf default) (recursive), label 16, seg6 100:1::100,200:1::200, srv6(endpoint|color):1::1|100, weight 1

• fe80::a8c1:abff:fe5c:7e19, via eth3(vrf default), label 16, seg6 100:1::100,200:1::200, srv6(endpoint|color):fe80::a8c1:abff:fe5c:7e19|0, weight 1
• fe80::a8c1:abff:feb5:6de9, via eth4(vrf default), label 16, seg6 100:1::100,200:1::200, srv6(endpoint|color):fe80::a8c1:abff:feb5:6de9|0, weight 1**_

[ton31337]

• Please reuse IPV[46]_* macros to keep the code maintable;
• Unified config for new topotests is mandatory;
• Some minor nits/cleanups for the code yet;
• frrbot + verify check also must be vanished.

[ton31337]

Is this basically the same as LIST_FOREACH (path, &(bnc->paths), nh_thread)? Then can we just move to the separate function and reuse? Because now we have lots of duplicated stuff + the indentation is bad at some level (due to nesting).

[guoguojia2021]

Sometimes, two BNC are needed, for example, one route has a color while the other route does not, and they have the same nexthop, the route with a color select SRv6 TE policy, and the other route select SRv6 BE

[pguibert6WIND]

Hi @guoguojia2021 , thanks for contribution.
Actually, there is a pull request #15057 already present.
It will be nice to compare both implems to see which one is best suited for our needs.