Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nhrp #571

Merged
merged 4 commits into from
May 18, 2017
Merged

Nhrp #571

merged 4 commits into from
May 18, 2017

Conversation

donaldsharp
Copy link
Member

Fixes issue #570 as well as grabs a commit Timo wanted in and fixes some missing newlines I noticed

donaldsharp and others added 3 commits May 17, 2017 18:30
@donaldsharp
nhrpd: Fix some missing newlines
201f627 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
nhrpd: Fix crash in 'no nhrp event socket..' command
d258c88 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@fabled @donaldsharp
nhrp: improve CIE prefix length handling
55fd6ee 
RFC2332 states that prefix length MUST be 0xff for unique bindings.
However, it seems at least some Cisco firmwares use host prefix
length instead (which on wire level makes sense). Relax the handling
of prefix length to treat all value longer than address length as
0xff. Additionally treat 0x00 the same way too, this is required
by the RFC. This also fixes the prefix length address family to be
checked against protocol address.
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-746/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

fabled
fabled approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@fabled fabled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clean ups look good. The prefix change should be OK, I've been waiting for testing feedback for it, but perhaps it should be just committed.

@fabled @donaldsharp
nhrpd: announce ipv6 routes to zebra
37dc8ab 
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-755/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 571, comparing to Git base SHA bac7b7b

Bug comparison statistics:

  • Fixed bugs: 0
  • New bugs: 0

142 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-755/artifact/shared/static_analysis/index.html

@eqvinox eqvinox merged commit 4d2d73c into FRRouting:master May 18, 2017
@donaldsharp donaldsharp mentioned this pull request May 20, 2017
Closed
@donaldsharp donaldsharp deleted the nhrp branch May 29, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabled fabled fabled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldsharp @NetDEF-CI @fabled @eqvinox