Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: [7.5] Backport maximum-prefix and show bgp neighbor routes for LU fixes #7291

Merged
merged 2 commits into from
Oct 13, 2020
Merged

bgpd: [7.5] Backport maximum-prefix and show bgp neighbor routes for LU fixes #7291

merged 2 commits into from
Oct 13, 2020

Conversation

ton31337
Copy link
Member

@polychaeta polychaeta added the bgp label Oct 13, 2020
@ton31337 ton31337 changed the title bgpd: Backport maximum-prefix and show bgp neighbor routes for LU fixes bgpd: [7.5] Backport maximum-prefix and show bgp neighbor routes for LU fixes Oct 13, 2020
@donaldsharp @ton31337
bgpd: Correctly calculate threshold being reached
b61afc4 
if (pcout > (pcount * peer->max_threshold[afi][safi] / 100 ))
is always true.  So the very first route received will always
trigger the warning.  We actually want the warning to happen
when we hit the threshold.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 13, 2020 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:10144:12: note: declared here
10144 | static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }
Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/F29BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/DEB10BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }
FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12680:62: error: 'show_flags' undeclared (first use in this function); did you mean 'chflags'?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function 'bgp_show'
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/FBSD12AMD64/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI005BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory `/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:2: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U1804AMD64/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }
Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

lib/vty.c:363:2: note: #pragma message: Please remove solaris code from system as it is deprecated
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U1804PPC64LEBUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI021BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI011BUILD/ErrorLog/log_make.txt)

1 warning generated.
copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c:12680:62: error: use of undeclared identifier 'show_flags'
1 error generated.
gmake[1]: *** [Makefile:7937: bgpd/bgp_route.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.14706/frr-source'
gmake: *** [Makefile:4717: all] Error 2

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI012BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12680:62: error: 'show_flags' undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function 'bgp_show'
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI014BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI009BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12680:62: error: 'show_flags' undeclared (first use in this function); did you mean 'chflags'?
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function 'bgp_show'
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:10144:12: note: declared here
10144 | static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14706/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14706/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 13, 2020 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
12664 |   SET_FLAG(show_flags, BGP_SHOW_OPT_JSON);
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
12664 |   SET_FLAG(show_flags, BGP_SHOW_OPT_JSON);
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show
Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function); did you mean BGP_SOFT_OUT_STR?
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function); did you mean BGP_SOFT_OUT_STR?
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U1804PPC64LEBUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function); did you mean BGP_SOFT_OUT_STR?
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/F29BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U1604I386/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show
CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:2: error: too few arguments to function bgp_show

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function); did you mean BGP_SOFT_OUT_STR?
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show
Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show
Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI008BLD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function); did you mean BGP_SOFT_OUT_STR?
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/DEB10BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12664:24: error: 'BGP_SHOW_OPT_JSON' undeclared (first use in this function); did you mean 'BGP_SOFT_OUT_STR'?
./lib/zebra.h:393:38: note: in definition of macro 'SET_FLAG'
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro 'SET_FLAG'
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function 'bgp_show'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/FBSD12AMD64/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI011BUILD/ErrorLog/log_make.txt)

1 warning generated.
copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c:12664:24: error: use of undeclared identifier 'BGP_SHOW_OPT_JSON'
bgpd/bgp_route.c:12685:72: error: too few arguments to function call, expected 8, have 7
bgpd/bgp_route.c:10144:1: note: 'bgp_show' declared here
static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
^
2 errors generated.
gmake[1]: *** [Makefile:7937: bgpd/bgp_route.o] Error 1

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12664:24: error: 'BGP_SHOW_OPT_JSON' undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro 'SET_FLAG'
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro 'SET_FLAG'
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function 'bgp_show'

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function)
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI014BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12664:24: error: 'BGP_SHOW_OPT_JSON' undeclared (first use in this function)
12664 |   SET_FLAG(show_flags, BGP_SHOW_OPT_JSON);
./lib/zebra.h:393:38: note: in definition of macro 'SET_FLAG'
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
12664 |   SET_FLAG(show_flags, BGP_SHOW_OPT_JSON);
./lib/zebra.h:393:38: note: in definition of macro 'SET_FLAG'
bgpd/bgp_route.c:12685:9: error: too few arguments to function 'bgp_show'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from bgpd/bgp_route.c:22:0:
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12664:24: error: BGP_SHOW_OPT_JSON undeclared (first use in this function); did you mean BGP_SOFT_OUT_STR?
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12664:24: note: each undeclared identifier is reported only once for each function it appears in
./lib/zebra.h:393:38: note: in definition of macro SET_FLAG
 #define SET_FLAG(V,F)        (V) |= (F)
bgpd/bgp_route.c:12685:9: error: too few arguments to function bgp_show

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14705/artifact/U1804AMD64/config.status/config.status

@ton31337
bgpd: fix show bgp neighbor routes for labeled-unicast
9a4f152 
bgp_show_neighbor_route() was rewriting safi from LU to uni
before checking if the peer was enabled for LU.  This resulted
in the peer's address-family check looking for unicast, which
would always fail for LU peers since unicast + LU are
mutually-exclusive AFIs.
This moves this safi reassignment after the peer AFI check,
ensuring that the peer's address-family check looks for LU
while the call to bgp_show() still uses uni.

-- highlights from manual testing

config:

router bgp 2
 neighbor 1.1.1.1 remote-as external
 neighbor 1.1.1.1 disable-connected-check
 neighbor 1.1.1.1 update-source 2.2.2.2
 !
 address-family ipv4 unicast
  no neighbor 1.1.1.1 activate
 exit-address-family
 !
 address-family ipv4 labeled-unicast
  neighbor 1.1.1.1 activate
 exit-address-family

before:

spine01# show bgp ipv4 unicast neighbors 1.1.1.1 routes
% No such neighbor or address family
spine01# show bgp ipv4 labeled-unicast neighbors 1.1.1.1 routes
% No such neighbor or address family

after:

spine01# show bgp ipv4 unicast neighbors 1.1.1.1 routes
% No such neighbor or address family
spine01# show bgp ipv4 label neighbors 1.1.1.1 routes
BGP table version is 1, local router ID is 2.2.2.2
Status codes: s suppressed, d damped, h history, * valid, > best, = multipath,
              i internal, r RIB-failure, S Stale, R Removed
Origin codes: i - IGP, e - EGP, ? - incomplete
   Network          Next Hop            Metric LocPrf Weight Path
*> 11.11.11.11/32   1.1.1.1                  0             0 1 i
Displayed  1 routes and 1 total paths

Signed-off-by: Trey Aspelund <taspelund@cumulusnetworks.com>
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 13, 2020 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:10144:12: note: declared here
10144 | static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/DEB10BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/DEB10BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/F29BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/F29BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12680:62: error: 'show_flags' undeclared (first use in this function); did you mean 'chflags'?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function 'bgp_show'
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U1604I386/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }
Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI008BLD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI021BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI009BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12680:62: error: 'show_flags' undeclared (first use in this function); did you mean 'chflags'?
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function 'bgp_show'
12680 |  return bgp_show(vty, peer->bgp, afi, safi, type, &peer->su, show_flags);
bgpd/bgp_route.c:10144:12: note: declared here
10144 | static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

lib/vty.c:363:2: note: #pragma message: Please remove solaris code from system as it is deprecated
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U1804PPC64LEBUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI011BUILD/ErrorLog/log_make.txt)

1 warning generated.
copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c:12680:62: error: use of undeclared identifier 'show_flags'
1 error generated.
gmake[1]: *** [Makefile:7937: bgpd/bgp_route.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.14708/frr-source'
gmake: *** [Makefile:4717: all] Error 2

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI012BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
bgpd/bgp_route.c: In function 'bgp_show_neighbor_route':
bgpd/bgp_route.c:12680:62: error: 'show_flags' undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function 'bgp_show'
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI012BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }
Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI014BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI005BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory `/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function)
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:2: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14708/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14708/frr-source'
bgpd/bgp_route.c: In function bgp_show_neighbor_route:
bgpd/bgp_route.c:12680:62: error: show_flags undeclared (first use in this function); did you mean ifr_flags?
bgpd/bgp_route.c:12680:62: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgp_route.c:12680:9: error: too few arguments to function bgp_show
bgpd/bgp_route.c:10144:12: note: declared here
 static int bgp_show(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
bgpd/bgp_route.c:12681:1: error: control reaches end of non-void function [-Werror=return-type]
 }

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14709/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14709/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20201013-01-g9a4f15228-0 (missing) -> 7.5-dev-20201013-01-g9a4f15228-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20201013-01-g9a4f15228-0 (missing) -> 7.5-dev-20201013-01-g9a4f15228-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20201013-01-g9a4f15228-0 (missing) -> 7.5-dev-20201013-01-g9a4f15228-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20201013-01-g9a4f15228-0 (missing) -> 7.5-dev-20201013-01-g9a4f15228-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20201013-01-g9a4f15228-0 (missing) -> 7.5-dev-20201013-01-g9a4f15228-0~deb10u1

@donaldsharp donaldsharp merged commit 0b27ab2 into FRRouting:dev/7.5 Oct 13, 2020
@ton31337 ton31337 deleted the feature/bgpd_backports_7.5 branch October 22, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srimohans srimohans srimohans approved these changes

Assignees
No one assigned
Labels
bgp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ton31337 @NetDEF-CI @srimohans @donaldsharp @polychaeta