Fixing the behavior of --dep with --extract #2389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2385
From CHANGES.md:
The behavior of the --extract option was changed so that it no
longer treats the OCaml and Kremlin targets
differently. Previously, when used with --dep full, F* would
disregard the --extract setting when emitting the
ALL_KRML_FILES
variable.From the new message associated with fstar --help:
I also have patches to hacl-star, mitls-fstar and kremlin to accommodate this change.
With those patches, I have an everest green.