Improving Cygwin support #3642
Open
Improving Cygwin support #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F* should not try to do this for the user, and running an external process for this is definitely not ideal. Also it's not clear what advantage this had: in Windows, we would not have a cygpath to call, and in Cygwin, we can properly interpret both POSIX and Windows paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered recently that F* was pretty much not working at all in Cygwin due to a confusion in the handling of path names. This PR adds a workaround for it so that F* can even begin to work, but the issue should be fixed upstream in batteries. Regardless, I think many other things will fail to work.
This PR works around the issue, but also adds a big warning making F* refuse to run under Cygwin unless
FSTAR_CYGWINis set, to make it clear that this is not really supported.Note that we do test and routinely run native Windows versions of F*, compiled with MinGW. That is what makes up the Windows release. But there is no Cygwin CI test, and probably no one is running F* on it.
Mostly posting for visibility, I don't plan to merge this without discussion. Comments welcome!