In-place merge sort for slices #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also marks the element type argument of |
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Nov 9, 2024
|
There should be a way to make the sorting function constant stack space, by avoiding recursion and walking through the array/slice to merge adjacent subslices instead, but I'll do that in a separate PR |
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Nov 19, 2024
This reverts commit 5ff25c3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the implementations of in-place merge sort:
Pulse.Lib.ArraySwapintoPulse.Lib.Swap.Array(cf. Swapping two adjacent regions of an array of any sizes steel#12)Pulse.Lib.Swap.Sliceto swap the contents of two adjacent regions within a slicePulse.Lib.Array.MergeSortintoPulse.Lib.Sort.Merge.Array(cf. In-place array merge sort #245 )Pulse.Lib.Sort.Merge.Sliceto sort the contents of a slice using in-place merge sort. (Like the array implementation, it is optimized for memory consumption rather than speed.)