✂️ a few simple fixes~ #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifically, mommy now correctly creates a discussions thread and creates the tag at 'main' instead of at 'dev'~ and she adds a few non-breaking spaces to the readme~
FWDekker
added
bug
FWDekker
force-pushed
the
simple-fixes
branch
2 times, most recently
from
ebb01c0 to
0724409
Compare
FWDekker
force-pushed
the
simple-fixes
branch
4 times, most recently
from
8813dbf to
09bb267
Compare
FWDekker
commented
Nov 29, 2023
| @@ -244,7 +247,6 @@ jobs: | |||
| echo "::endgroup::" | |||
|
|
|||
| echo "::group::Commit changes" | |||
| git add --all | |||
There was a problem hiding this comment.
this line did nothing since commit -a already stages all files~
FWDekker
commented
Nov 29, 2023
| @@ -181,7 +181,8 @@ fill_template() { | |||
| -e "s/%%THEY%%/$they/g" \ | |||
| -e "s/%%THEM%%/$them/g" \ | |||
| -e "s/%%THEIR%%/$their/g" \ | |||
| -e "s/%%CAREGIVER%%/$caregiver/g")" | |||
| -e "s/%%CAREGIVER%%/$caregiver/g" \ | |||
| -e "s/%%N%%/\\$n/g")" | |||
There was a problem hiding this comment.
this is the only format that i could find that works universally on all systems~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58 and fixes #81~
also ensures that creating a discussions thread during a release (which was introduced in #73) actually works now (unlike when i tried to deploy v1.2.6)~
additionally, while fixing #58, i found that the scripts for testing homebrew and aur actually didn't test whether those packages would still work after pointing to the updated code; they only tested whether the new tests would work with the old release, which is quite weird. therefore, the relevant code has been updated to patch the references appropriately, hence this commit in
aur-mommy. and i had to add arelevant_shaenv variable because there is no single variable during an action that gives the sha of the current head in bothpull_requestandpushevents~