Fix Ctrl+A and Ctrl+End fold navigation (#986)

FXMisc · Nov 30, 2020 · 3af16d3 · 3af16d3
1 parent feb2700
commit 3af16d3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/richtextfx/src/main/java/org/fxmisc/richtext/GenericStyledArea.java b/richtextfx/src/main/java/org/fxmisc/richtext/GenericStyledArea.java
@@ -1470,6 +1470,10 @@ private void skipOverFoldedParagraphs( ObservableValue<? extends Integer> ob, In
     {
         if ( getCell( newParagraph ).isFolded() )
         {
+            // Prevent Ctrl+A and Ctrl+End breaking when the last paragraph is folded
+            // github.com/FXMisc/RichTextFX/pull/965#issuecomment-706268116
+            if ( newParagraph == getParagraphs().size() - 1 ) return;
+
             int skip = (newParagraph - prevParagraph > 0) ? +1 : -1;
             int p = newParagraph + skip;
 

diff --git a/richtextfx/src/main/java/org/fxmisc/richtext/ParagraphText.java b/richtextfx/src/main/java/org/fxmisc/richtext/ParagraphText.java
@@ -240,7 +240,7 @@ public Paragraph<PS, SEG, S> getParagraph() {
 
     public <T extends Node & Caret> double getCaretOffsetX(T caret) {
         layout(); // ensure layout, is a no-op if not dirty
-        checkWithinParagraph(caret);
+        if ( isVisible() /* notFolded */ ) checkWithinParagraph(caret);
         Bounds bounds = caret.getLayoutBounds();
         return (bounds.getMinX() + bounds.getMaxX()) / 2;
     }