Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mouse behavior override properties FXML-friendly #655

Closed
JordanMartinez opened this issue Nov 24, 2017 · 4 comments
Closed

Make mouse behavior override properties FXML-friendly #655

JordanMartinez opened this issue Nov 24, 2017 · 4 comments

Comments

@JordanMartinez
Copy link
Contributor

Coming from #653, change the Consumer type of setOnMouseDrop and other related methods for overriding the default mouse behavior to EventHandler, so as to be FXML-friendly.

@Jugen
Copy link
Collaborator

Jugen commented Nov 24, 2017

I'm almost done, just one small thing I need help with.
I can't find a reference to onNewSelectionDragEnd anywhere (neither getOnNewSelectionDragEnd() nor onNewSelectionDragEndProperty()) ? I tried figuring out where it should be in GenericStyledAreaBehavior, but there's no obvious spot. Any suggestions .... ?

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Nov 24, 2017 via email

@Jugen
Copy link
Collaborator

Jugen commented Nov 24, 2017

After reviewing the code it appears (if I'm not mistaken :-) that the onNewSelectionDragEnd functionality hasn't been implemented, so I've taken the liberty of adding it as part of this issue - see PR.

JordanMartinez added a commit that referenced this issue Feb 9, 2018
@JordanMartinez
Copy link
Contributor Author

Closed by #656.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants