Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched generic style objects order: paragraph comes before text (<S, PS> ==> <PS, S>) #246

Merged
merged 1 commit into from
Jan 25, 2016
Merged

Switched generic style objects order: paragraph comes before text (<S, PS> ==> <PS, S>) #246

merged 1 commit into from
Jan 25, 2016

Conversation

JordanMartinez
Copy link
Contributor

No description provided.

@JordanMartinez
Copy link
Contributor Author

I noticed on EditableStyledDocument: Line 168 that I get a compile error now that get(Paragraph)StyleForInsertionAt(int position) method has been removed, so I switched to getParagraphStyleAtPosition() instead. Is that in accordance with your javadoc?

Edit: Nevermind, you already did that. I think I was looking at some other branch or something...

@TomasMikula
Copy link
Member

Great, thanks!

TomasMikula added a commit that referenced this pull request Jan 25, 2016
@TomasMikula
Merge pull request #246 from JordanMartinez/switchStyleObjectGenerics
7819ad6 
Switched generic style objects order: paragraph comes before text (<S, PS> ==> <PS, S>)
@TomasMikula TomasMikula merged commit 7819ad6 into FXMisc:master Jan 25, 2016
@TomasMikula TomasMikula mentioned this pull request Jan 25, 2016
Closed
@JordanMartinez JordanMartinez deleted the switchStyleObjectGenerics branch January 25, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @TomasMikula