Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom caret visibility dependencies and CSS for caret blink rate #318

Merged
merged 3 commits into from
May 24, 2016
Merged

Allow custom caret visibility dependencies and CSS for caret blink rate #318

merged 3 commits into from
May 24, 2016

Conversation

JordanMartinez
Copy link
Contributor

No description provided.

shoaniki and others added 2 commits May 16, 2016 22:18
To implement one's custom dependency, one can follow the general idea of:
````java
ObservableValue<Boolean> p = // creation code;
area.showCaretProperty().bind(Val.map(p, b -> b ? CaretVisibility.ON : CaretVisibility.OFF));
````
@JordanMartinez JordanMartinez changed the title Show caret Allow custom caret visibility dependencies and CSS for caret blink rate May 23, 2016

@Override
public String getName() {
return "highlightTextFill";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy&paste typo? :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe! 😅

Since "javafx.util.Duration" is different from "java.time.Duration" there's an annoying conversion stage in `booleanPulse` that is necessary.
@TomasMikula
Copy link
Member

👍

@TomasMikula TomasMikula merged commit 2d34cef into FXMisc:master May 24, 2016
@JordanMartinez JordanMartinez deleted the showCaret branch May 26, 2016 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants