Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get viewport height; show paragraph region; clean up source code (boilerplate & organization) #632

Merged
merged 7 commits into from
Oct 27, 2017
Merged

Get viewport height; show paragraph region; clean up source code (boilerplate & organization) #632

merged 7 commits into from
Oct 27, 2017

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Oct 27, 2017

Adds API to get the viewport's height and show a specific region of a given paragraph

Otherwise, cleans up the source code a bit more by

  • removing unused methods
  • using properties and default methods to reduce boilerplate
  • put package-private and private methods in their own spots in the source code.

@JordanMartinez JordanMartinez changed the title Viewport height and reduce boilerplate Get viewport height; show paragraph region; clean up source code (boilerplate & organization) Oct 27, 2017
@JordanMartinez JordanMartinez merged commit e4ad3b3 into FXMisc:master Oct 27, 2017
@JordanMartinez JordanMartinez deleted the viewportHeightAndReduceBoilerplate branch October 27, 2017 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant