Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMQ Cleanup #146

Merged
merged 4 commits into from
Feb 20, 2024
Merged

ZMQ Cleanup #146

merged 4 commits into from
Feb 20, 2024

Conversation

martindale
Copy link
Member

Resolve issues with ZMQ

@martindale martindale changed the base branch from master to feature/v0.1.0-RC1 January 28, 2024 23:18
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d5db2dc) 60.49% compared to head (843038f) 60.61%.

Files Patch % Lines
types/environment.js 53.84% 6 Missing ⚠️
types/wallet.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/v0.1.0-RC1     #146      +/-   ##
======================================================
+ Coverage               60.49%   60.61%   +0.11%     
======================================================
  Files                      65       65              
  Lines                   15728    15750      +22     
======================================================
+ Hits                     9515     9547      +32     
+ Misses                   6213     6203      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martindale
Copy link
Member Author

Downstream reports that ZMQ still generates intermittent failures, sometimes unavailable during the install process, but randomly (?)

@martindale martindale added this to the 0.1 — Prototype milestone Feb 9, 2024
@martindale martindale added the enhancement New functionality label Feb 9, 2024
@martindale martindale merged commit 59b7d26 into feature/v0.1.0-RC1 Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality
Projects
Status: Computing
Development

Successfully merging this pull request may close these issues.

1 participant