Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoreShaderRegistrationCallback mixin #3886

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix CoreShaderRegistrationCallback mixin #3886

merged 1 commit into from
Jun 25, 2024

Conversation

modmuss50
Copy link
Member

Superseeds #3521
Fixes #3230

@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Jun 25, 2024
@modmuss50 modmuss50 mentioned this pull request Jun 25, 2024
Closed
mysticdrew
mysticdrew approved these changes Jun 25, 2024
View reviewed changes
Copy link

@mysticdrew mysticdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good, thanks for the quick turnaround!

@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Jun 25, 2024
@modmuss50 modmuss50 merged commit 5a8c785 into FabricMC:1.21 Jun 25, 2024
4 checks passed
modmuss50 added a commit that referenced this pull request Jun 25, 2024
@modmuss50
Fix CoreShaderRegistrationCallback mixin (#3886)
850ef40 
(cherry picked from commit 5a8c785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticdrew mysticdrew mysticdrew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge me please Pull requests that are ready to merge priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoreShaderRegistrationCallback is called multiple times on shader reload in 1.20.x
2 participants
@modmuss50 @mysticdrew