Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish porting Model Loading, FRAPI, and Indigo to 24w33a #4043

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Finish porting Model Loading, FRAPI, and Indigo to 24w33a #4043

merged 1 commit into from
Aug 21, 2024

Conversation

PepperCode1
Copy link
Member

Model Loading received multiple breaking changes. One new experimental method was added to FRAPI.

@modmuss50 modmuss50 added port Porting existing code to a different version priority:high High priority PRs that need review and work now. Review these first. labels Aug 20, 2024
@modmuss50 modmuss50 requested a review from a team August 20, 2024 19:06
modmuss50
modmuss50 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this a great help <3

Looks good to my untrained eye, I'll merge it before the snapshot tomorrow if no one has any objections. Thanks again.

@modmuss50 modmuss50 merged commit 236902d into FabricMC:1.21.2 Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
port Porting existing code to a different version priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PepperCode1 @modmuss50