Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operator item group event #4045

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix operator item group event #4045

merged 1 commit into from
Aug 26, 2024

Conversation

AshyBoxy
Copy link
Contributor

This fixes #4044

@modmuss50 modmuss50 added the bug Something isn't working label Aug 20, 2024
modmuss50
modmuss50 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable, previously it left it in the modders hand but there was little reason to do that and as you found broke the page count.

@modmuss50 modmuss50 added small change merge me please Pull requests that are ready to merge labels Aug 21, 2024
@modmuss50 modmuss50 merged commit 3fc0e55 into FabricMC:1.21.1 Aug 26, 2024
4 checks passed
modmuss50 pushed a commit that referenced this pull request Aug 26, 2024
@AshyBoxy @modmuss50
Dont invoke ItemGroupEvents.MODIFY_ENTRIES_ALL for the OP tab, when t…
ca1fb63 
…he OP tab is disabled (#4045)

(cherry picked from commit 3fc0e55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge me please Pull requests that are ready to merge small change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OP tab still showing when stacks have been added, even though it's disabled in options
2 participants
@AshyBoxy @modmuss50