Add c:animal_foods tag
#4080
Merged
Add c:animal_foods tag
#4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Sep 10, 2024
|
@modmuss50 I ran the datagen for the convention tags v2 module and no change. I don't see what specific resource is not matching |
|
Ill take a look, I should improve the github actions to actually show the diff... |
modmuss50
reviewed
Sep 10, 2024
...-convention-tags-v2/src/generated/resources/assets/fabric-convention-tags-v2/lang/en_us.json
Outdated
Show resolved
Hide resolved
modmuss50
approved these changes
Sep 10, 2024
|
It still failed! |
modmuss50
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tag to collect all the new mojang food tags into one parent tag so modders can use this to validate if an item is a feed item for some unknown animal. May make sorting easier or allow stocking up animal feeding machines without non-feedable items slipping in. Railcraft Reborn had a specific use case for this (see Neo PR)
Closes: #4036
Neoforge PR: neoforged/NeoForge#1465