-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rzCOBS encoding #15
Conversation
I somehow missed this PR.. Think i accidentally unwatched my own repo, sorry about that! But AWESOME work! I think you need to disable the std feature on rzCOBS? |
@MathiasKoch std is used for decoding during testing (see dev-dependencies section). Not sure why it's being used during the build. On the other hand, it's working in my firmware when |
Hmm.. Not sure why the tests fail then? |
@eupn Can you merge master into this? |
@MathiasKoch rebased on the latest master. |
Hmm.. still seems to fail? |
@MathiasKoch, I think this rust-lang/cargo#1596 is related to this issue with CI builds. P.S.: people have similar issues here rafalh/rust-fatfs#39 with |
@MathiasKoch seems that feature resolver v2 fixes the issue. |
Ahh perfect! Great catch 👍 |
Obvious in a hindsight, but works perfectly fine with a
0xFF
as a sentinel byte.Closes #12.
Related
defmt-persist-print
PR: https://github.com/eupn/defmt-persist-print/1.P.S.: tested in hardware, works fine!