-
Notifications
You must be signed in to change notification settings - Fork 5
Pull request requirements
Artem Kalmykov edited this page Aug 29, 2020
·
2 revisions
Before submitting a PR, please make sure to:
- Cover possible edge cases and side effects of your change.
- Make screenshots of your change, if it affects the UI.
- Check that your changes work correctly on all supported platforms.
- Verify that UI works correctly on the devices with/without a Home button and in Light and Dark styles.
- Add unit tests for the new logic and achieve maximum possible code coverage.
- Fix all the warnings (including SwiftLint warnings).
During the PR creation please follow the template and do the following:
- Add description of the problem which you are solving with this pull request.
- Explain how you solved the problem.
- Mark all the checkboxes (and actually do that, not only mark).
- Assign appropriate labels.
- Assign yourself as an assignee.
- Assign some reviewers including @Artem-Kalmykov.
- If your PR fixes some issue, make sure to link that issue to the PR.